Bugs item #3472493, was opened at 2012-01-11 09:57
Message generated for change (Settings changed) made by freyther
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3472493&group_id=167540
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Synchronisation / Invitation
Group: None
Status: Closed
Resolution: Invalid
>Priority: 5
Private: No
Submitted By: Alexander Waldmann (netcorps)
Assigned to: Alexander Waldmann (netcorps)
Summary: Non-Host users cannot add buddies to session
Initial Comment:
Non-Host users cannot add buddies to the session, because the
Session-Constructor does not properly initialize the "freeColors" attribute.
OutgoingSessionNegotiation result = new OutgoingSessionNegotiation(toInvite,
sarosSession.getFreeColor(), sarosSession, description,
sarosContext);
calls sarosSession.getFreeColor(), but yields NullPointerException for
non-hosts because SarosSession.freeColor is null.
There are 3 different constructors, only 1 fills the freeColor attribute
properly...
Suggested fix: lazy initialization of freeColor in the get-method on first call
in SarosSession Implementation
Alternative: move
this.freeColors = new FreeColors(MAX_USERCOLORS - 1);
to protected internal base constructor
protected SarosSession(ITransmitter transmitter,
DispatchThreadContext threadContext, int myColorID,
DateTime sessionStart, SarosContext sarosContext) {
....
this.localUser = new User(this, sarosNet.getMyJID(), myColorID);
this.freeColors = new FreeColors(MAX_USERCOLORS - 1);
.....
----------------------------------------------------------------------
Comment By: Stefan Rossbach (kargor)
Date: 2012-02-01 15:49
Message:
Please make a requirement analyse and post this on the feature tracker.
----------------------------------------------------------------------
Comment By: Stefan Rossbach (kargor)
Date: 2012-01-20 00:47
Message:
I do not think that it is a good idea that everyone can invite everybody
into an existing session. I even think that the code is not designed to
fullfill this "requirement".
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3472493&group_id=167540
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
