On 22 January 2018 at 15:44, Matt Roper <[email protected]> wrote: > drm_set_cgrp_param is a simple tool to set DRM parameters associated with a > cgroup. It is intended to be called at system initialization time (e.g., from > a sysv-init script or systemd service) to configure graphics policy and > resource management according to the wishes of the system integrator. > > Signed-off-by: Matt Roper <[email protected]> > --- > configure.ac | 1 + > tests/Makefile.am | 2 +- > tests/drm_set_cgrp_param/Makefile.am | 18 ++++++ > tests/drm_set_cgrp_param/drm_set_cgrp_param.c | 80 > +++++++++++++++++++++++++++ > 4 files changed, 100 insertions(+), 1 deletion(-) > create mode 100644 tests/drm_set_cgrp_param/Makefile.am > create mode 100644 tests/drm_set_cgrp_param/drm_set_cgrp_param.c > Hi Matt,
Adding a small test/demo in libdrm sounds good. Although I think we need some IGT tests, if you haven't prepped them already. After all we need to ensure the kernel correctly validates and errors when we feed it the wrong info through the IOCTL. There's a small suggestions about the IOCTL design. s/reserved/flags/ to make future extension are possible - as mentioned in [2] Thanks Emil [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/ioctl/botching-up-ioctls.txt?h=v4.15-rc9#n64 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
