On Mon, Mar 05, 2018 at 10:12:21AM +0530, Viresh Kumar wrote:
> On 02-03-18, 14:56, Jordan Crouse wrote:
> > Add the nodes and other bits to describe the Adreno GPU and GMU
> > devices.
> > 
> > Change-Id: Ibf4dc0ebb0ac03d8b6b8e65747e142c440e70b0a
> 
> Remove it ?

* Shakes fist at Gerrit *

> > Signed-off-by: Jordan Crouse <jcro...@codeaurora.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845.dtsi | 120 
> > +++++++++++++++++++++++++++++++++++
> >  1 file changed, 120 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi 
> > b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 7b5c16eb63b7..cc6d367ee55e 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -312,5 +312,125 @@
> >                             status = "disabled";
> >                     };
> >             };
> > +
> > +           adreno_smmu: arm,smmu-adreno@5040000 {
> > +                   compatible = "qcom,msm8996-smmu-v2";
> > +                   reg = <0x5040000 0x10000>;
> > +                   #iommu-cells = <1>;
> > +                   #global-interrupts = <2>;
> > +                   interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_HIGH>,
> > +                                <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>,
> > +                                <GIC_SPI 364 IRQ_TYPE_EDGE_RISING>,
> > +                                <GIC_SPI 365 IRQ_TYPE_EDGE_RISING>,
> > +                                <GIC_SPI 366 IRQ_TYPE_EDGE_RISING>,
> > +                                <GIC_SPI 367 IRQ_TYPE_EDGE_RISING>,
> > +                                <GIC_SPI 368 IRQ_TYPE_EDGE_RISING>,
> > +                                <GIC_SPI 369 IRQ_TYPE_EDGE_RISING>,
> > +                                <GIC_SPI 370 IRQ_TYPE_EDGE_RISING>,
> > +                                <GIC_SPI 371 IRQ_TYPE_EDGE_RISING>;
> > +                   clocks = <&clock_gcc GCC_GPU_MEMNOC_GFX_CLK>,
> > +                            <&clock_gcc GCC_GPU_CFG_AHB_CLK>;
> > +                   clock-names = "bus", "iface";
> > +
> > +                   power-domains = <&clock_gpucc GPU_CX_GDSC>;
> > +           };
> > +
> > +           gpu_opp_table: adreno-opp-table {
> > +                   compatible = "operating-points-v2";
> > +
> > +                   opp-710000000 {
> > +                           opp-hz = /bits/ 64 <710000000>;
> > +                           qcom,arc-level = <416>;
> 
> I am not sure if I saw where this is defined ?

I'm glad you brought this up - I was trying to find a place in the documentation
to put it, but since target specific nodes would be a new trick for OPP I didn't
quite know how to go about doing it. Do we just list them as Optional: or
should we add a target specific section to the documentation and list them out
there instead?

Jordan

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to