Hi Laurent : ) On 04/19/2018 10:11 AM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Tuesday, 10 April 2018 08:19:26 EEST Philippe Cornu wrote: >> Add the 3 optional power supplies using the exact description >> found in the document named >> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". >> >> Signed-off-by: Philippe Cornu <philippe.co...@st.com> >> --- >> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt >> b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index >> 56a3e68ccb80..cf53678fe574 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt >> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt >> @@ -8,6 +8,9 @@ Optional properties: >> - interrupts-extended or interrupt-parent + interrupts: describe >> the interrupt line used to inform the host about hotplug events. >> - reset-gpios: OF device-tree gpio specification for RST_N pin. >> + - iovcc-supply: I/O supply voltage (1.8V or 3.3V, host-dependent). >> + - avcc12-supply: TMDS analog supply voltage (1.2V). >> + - cvcc12-supply: Digital core supply voltage (1.2V). > > It seems that the AVCC12 and CVCC12 power supplies are usually derived from > the same source. How about starting with one DT property for both, and adding > a second one later if needed ? >
Well, I do not know what is the best. Here I took the description from the documentation, and to allow all possible board configurations, I added these supplies as "optional" properties: if there is only one 1v2 regulator on the board, the dt will contain only avcc12 or cvcc12 and everything will work fine (we will have a dummy regulator for the missing optional 1v2 reg), if both regulators are there for any reasons (stability, noise, whatever...) then both entries will be in the dt. If you confirm you prefer a single 1v2 supply (named for instance "vcc12-supply") then I will do :-) Many thanks, Philippe >> Optional subnodes: >> - video input: this subnode can contain a video input port node > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
