these two enumerated types are same for now. both of them might change in the
future.
I have not used clang, but would .block_id = (int)head->block fix your
warning? If such change is acceptable, I can make one then.
Thanks
xinhui
-----Original Message-----
From: Nathan Chancellor <natechancel...@gmail.com>
Sent: 2019年3月20日 8:54
To: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian
<christian.koe...@amd.com>; Zhou, David(ChunMing) <david1.z...@amd.com>; Pan,
Xinhui <xinhui....@amd.com>
Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
linux-ker...@vger.kernel.org; clang-built-li...@googlegroups.com
Subject: Clang warning in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
Hi all,
The introduction of this file in commit dbd249c24427 ("drm/amdgpu: add
amdgpu_ras.c to support ras (v2)") introduces the following Clang
warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:544:23: warning: implicit conversion
from enumeration type 'enum amdgpu_ras_block' to different enumeration type
'enum ta_ras_block' [-Wenum-conversion]
.block_id = head->block,
~~~~~~^~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:545:24: warning: implicit conversion
from enumeration type 'enum amdgpu_ras_error_type' to different enumeration
type 'enum ta_ras_error_type' [-Wenum-conversion]
.error_type = head->type,
~~~~~~^~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:549:23: warning: implicit conversion
from enumeration type 'enum amdgpu_ras_block' to different enumeration type
'enum ta_ras_block' [-Wenum-conversion]
.block_id = head->block,
~~~~~~^~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:550:24: warning: implicit conversion
from enumeration type 'enum amdgpu_ras_error_type' to different enumeration
type 'enum ta_ras_error_type' [-Wenum-conversion]
.error_type = head->type,
~~~~~~^~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:650:26: warning: implicit conversion
from enumeration type 'enum amdgpu_ras_block' to different enumeration type
'enum ta_ras_block' [-Wenum-conversion]
.block_id = info->head.block,
~~~~~~~~~~~^~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:651:35: warning: implicit conversion
from enumeration type 'enum amdgpu_ras_error_type' to different enumeration
type 'enum ta_ras_error_type' [-Wenum-conversion]
.inject_error_type = info->head.type,
~~~~~~~~~~~^~~~
6 warnings generated.
Normally, I would sent a fix for this myself but I am not entirely sure why
these two enumerated types exist when one would do since they have the same
values minus the prefix. In fact, the ta_ras_{block,error_type} values are
never used aside from being defined. Some clarification would be appreciated.
Thank you,
Nathan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
