Hi Carlis,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.11-rc5 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Carlis/fbtft-add-tearing-signal-detect/20210125-210428
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 
ec52736c35f29ed96a45e641dd6aad61bc9cb6f7
config: x86_64-randconfig-r034-20210126 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 
925ae8c790c7e354f12ec14a6cac6aa49fc75b29)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # 
https://github.com/0day-ci/linux/commit/480797ed48b87555bb31a8a07b600959b53fe643
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Carlis/fbtft-add-tearing-signal-detect/20210125-210428
        git checkout 480797ed48b87555bb31a8a07b600959b53fe643
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/fbtft/fb_st7789v.c:216:5: warning: no previous prototype for 
>> function 'st7789v_write_vmem16_bus8' [-Wmissing-prototypes]
   int st7789v_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t 
len)
       ^
   drivers/staging/fbtft/fb_st7789v.c:216:1: note: declare 'static' if the 
function is not intended to be used outside of this translation unit
   int st7789v_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t 
len)
   ^
   static 
   1 warning generated.


vim +/st7789v_write_vmem16_bus8 +216 drivers/staging/fbtft/fb_st7789v.c

   208  
   209  
/*****************************************************************************
   210   *
   211   *   int (*write_vmem)(struct fbtft_par *par);
   212   *
   213   
*****************************************************************************/
   214  
   215  /* 16 bit pixel over 8-bit databus */
 > 216  int st7789v_write_vmem16_bus8(struct fbtft_par *par, size_t offset, 
 > size_t len)
   217  {
   218          u16 *vmem16;
   219          __be16 *txbuf16 = par->txbuf.buf;
   220          size_t remain;
   221          size_t to_copy;
   222          size_t tx_array_size;
   223          int i;
   224          int rc, ret = 0;
   225          size_t startbyte_size = 0;
   226  
   227          fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "st7789v ---%s(offset=%zu, 
len=%zu)\n",
   228                        __func__, offset, len);
   229  
   230          remain = len / 2;
   231          vmem16 = (u16 *)(par->info->screen_buffer + offset);
   232  
   233          if (par->gpio.dc)
   234                  gpiod_set_value(par->gpio.dc, 1);
   235  
   236          /* non buffered write */
   237          if (!par->txbuf.buf)
   238                  return par->fbtftops.write(par, vmem16, len);
   239  
   240          /* buffered write */
   241          tx_array_size = par->txbuf.len / 2;
   242  
   243          if (par->startbyte) {
   244                  txbuf16 = par->txbuf.buf + 1;
   245                  tx_array_size -= 2;
   246                  *(u8 *)(par->txbuf.buf) = par->startbyte | 0x2;
   247                  startbyte_size = 1;
   248          }
   249  
   250          while (remain) {
   251                  to_copy = min(tx_array_size, remain);
   252                  dev_dbg(par->info->device, "    to_copy=%zu, 
remain=%zu\n",
   253                          to_copy, remain - to_copy);
   254  
   255                  for (i = 0; i < to_copy; i++)
   256                          txbuf16[i] = cpu_to_be16(vmem16[i]);
   257  
   258                  vmem16 = vmem16 + to_copy;
   259                  if (par->gpio.te) {
   260                          enable_spi_panel_te_irq(par, true);
   261                          reinit_completion(&spi_panel_te);
   262                          rc = wait_for_completion_timeout(&spi_panel_te,
   263                                                           
msecs_to_jiffies(SPI_PANEL_TE_TIMEOUT));
   264                          if (rc == 0)
   265                                  pr_err("wait panel TE time out\n");
   266                  }
   267                  ret = par->fbtftops.write(par, par->txbuf.buf,
   268                                                                  
startbyte_size + to_copy * 2);
   269                  if (par->gpio.te)
   270                          enable_spi_panel_te_irq(par, false);
   271                  if (ret < 0)
   272                          return ret;
   273                  remain -= to_copy;
   274          }
   275  
   276          return ret;
   277  }
   278  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to