[Public] > -----Original Message----- > From: Kees Cook <keesc...@chromium.org> > Sent: Monday, May 22, 2023 4:15 PM > To: Azeem Shaikh <azeemshaik...@gmail.com> > Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian > <christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; linux- > harden...@vger.kernel.org; amd-...@lists.freedesktop.org; linux- > ker...@vger.kernel.org; David Airlie <airl...@gmail.com>; Daniel Vetter > <dan...@ffwll.ch>; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH] drm/radeon: Replace all non-returning strlcpy with > strscpy > > On Mon, May 22, 2023 at 03:50:32PM +0000, Azeem Shaikh wrote: > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read overflows if a > > source string is not NUL-terminated [1]. > > In an effort to remove strlcpy() completely [2], replace > > strlcpy() here with strscpy(). > > No return values were used, so direct replacement is safe. > > > > [1] > > > https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 > > > > Signed-off-by: Azeem Shaikh <azeemshaik...@gmail.com> > > Reviewed-by: Kees Cook <keesc...@chromium.org> >
Acked-by: Alex Deucher <alexander.deuc...@amd.com> Ack to take this through whatever tree makes sense if you are trying to batch all of these up. Otherwise, I can pick them up. Alex
