On 9/4/2024 7:15 AM, Tejas Vipin wrote:
Changes the himax-hx83112a panel to use multi style functions for
improved error handling.

Signed-off-by: Tejas Vipin <tejasvipi...@gmail.com>

Reviewed-by: Jessica Zhang <quic_jessz...@quicinc.com>

---
  drivers/gpu/drm/panel/panel-himax-hx83112a.c | 297 +++++++++----------
  1 file changed, 136 insertions(+), 161 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-himax-hx83112a.c 
b/drivers/gpu/drm/panel/panel-himax-hx83112a.c
index 466c27012abf..47bce087e339 100644
--- a/drivers/gpu/drm/panel/panel-himax-hx83112a.c
+++ b/drivers/gpu/drm/panel/panel-himax-hx83112a.c
@@ -56,198 +56,173 @@ static void hx83112a_reset(struct hx83112a_panel *ctx)
        msleep(50);
  }
-static int hx83112a_on(struct hx83112a_panel *ctx)
+static int hx83112a_on(struct mipi_dsi_device *dsi)
  {
-       struct mipi_dsi_device *dsi = ctx->dsi;
-       struct device *dev = &dsi->dev;
-       int ret;
+       struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
dsi->mode_flags |= MIPI_DSI_MODE_LPM; - mipi_dsi_dcs_write_seq(dsi, HX83112A_SETEXTC, 0x83, 0x11, 0x2a);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETPOWER1,
-                              0x08, 0x28, 0x28, 0x83, 0x83, 0x4c, 0x4f, 0x33);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETDISP,
-                              0x00, 0x02, 0x00, 0x90, 0x24, 0x00, 0x08, 0x19,
-                              0xea, 0x11, 0x11, 0x00, 0x11, 0xa3);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETDRV,
-                              0x58, 0x68, 0x58, 0x68, 0x0f, 0xef, 0x0b, 0xc0,
-                              0x0b, 0xc0, 0x0b, 0xc0, 0x00, 0xff, 0x00, 0xff,
-                              0x00, 0x00, 0x14, 0x15, 0x00, 0x29, 0x11, 0x07,
-                              0x12, 0x00, 0x29);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x02);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETDRV,
-                              0x00, 0x12, 0x12, 0x11, 0x88, 0x12, 0x12, 0x00,
-                              0x53);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x00);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x03);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETDGCLUT,
-                              0xff, 0xfe, 0xfb, 0xf8, 0xf4, 0xf1, 0xed, 0xe6,
-                              0xe2, 0xde, 0xdb, 0xd6, 0xd3, 0xcf, 0xca, 0xc6,
-                              0xc2, 0xbe, 0xb9, 0xb0, 0xa7, 0x9e, 0x96, 0x8d,
-                              0x84, 0x7c, 0x74, 0x6b, 0x62, 0x5a, 0x51, 0x49,
-                              0x41, 0x39, 0x31, 0x29, 0x21, 0x19, 0x12, 0x0a,
-                              0x06, 0x05, 0x02, 0x01, 0x00, 0x00, 0xc9, 0xb3,
-                              0x08, 0x0e, 0xf2, 0xe1, 0x59, 0xf4, 0x22, 0xad,
-                              0x40);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x02);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETDGCLUT,
-                              0xff, 0xfe, 0xfb, 0xf8, 0xf4, 0xf1, 0xed, 0xe6,
-                              0xe2, 0xde, 0xdb, 0xd6, 0xd3, 0xcf, 0xca, 0xc6,
-                              0xc2, 0xbe, 0xb9, 0xb0, 0xa7, 0x9e, 0x96, 0x8d,
-                              0x84, 0x7c, 0x74, 0x6b, 0x62, 0x5a, 0x51, 0x49,
-                              0x41, 0x39, 0x31, 0x29, 0x21, 0x19, 0x12, 0x0a,
-                              0x06, 0x05, 0x02, 0x01, 0x00, 0x00, 0xc9, 0xb3,
-                              0x08, 0x0e, 0xf2, 0xe1, 0x59, 0xf4, 0x22, 0xad,
-                              0x40);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x01);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETDGCLUT,
-                              0xff, 0xfe, 0xfb, 0xf8, 0xf4, 0xf1, 0xed, 0xe6,
-                              0xe2, 0xde, 0xdb, 0xd6, 0xd3, 0xcf, 0xca, 0xc6,
-                              0xc2, 0xbe, 0xb9, 0xb0, 0xa7, 0x9e, 0x96, 0x8d,
-                              0x84, 0x7c, 0x74, 0x6b, 0x62, 0x5a, 0x51, 0x49,
-                              0x41, 0x39, 0x31, 0x29, 0x21, 0x19, 0x12, 0x0a,
-                              0x06, 0x05, 0x02, 0x01, 0x00, 0x00, 0xc9, 0xb3,
-                              0x08, 0x0e, 0xf2, 0xe1, 0x59, 0xf4, 0x22, 0xad,
-                              0x40);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x00);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETDGCLUT, 0x01);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETTCON,
-                              0x70, 0x00, 0x04, 0xe0, 0x33, 0x00);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETPANEL, 0x08);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETPOWER2, 0x2b, 0x2b);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP0,
-                              0x80, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x08,
-                              0x08, 0x03, 0x03, 0x22, 0x18, 0x07, 0x07, 0x07,
-                              0x07, 0x32, 0x10, 0x06, 0x00, 0x06, 0x32, 0x10,
-                              0x07, 0x00, 0x07, 0x32, 0x19, 0x31, 0x09, 0x31,
-                              0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x00, 0x08,
-                              0x09, 0x30, 0x00, 0x00, 0x00, 0x06, 0x0d, 0x00,
-                              0x0f);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x01);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP0,
-                              0x00, 0x00, 0x19, 0x10, 0x00, 0x0a, 0x00, 0x81);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x00);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP1,
-                              0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
-                              0xc0, 0xc0, 0x18, 0x18, 0x19, 0x19, 0x18, 0x18,
-                              0x40, 0x40, 0x18, 0x18, 0x18, 0x18, 0x3f, 0x3f,
-                              0x28, 0x28, 0x24, 0x24, 0x02, 0x03, 0x02, 0x03,
-                              0x00, 0x01, 0x00, 0x01, 0x31, 0x31, 0x31, 0x31,
-                              0x30, 0x30, 0x30, 0x30, 0x2f, 0x2f, 0x2f, 0x2f);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP2,
-                              0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
-                              0x40, 0x40, 0x18, 0x18, 0x18, 0x18, 0x19, 0x19,
-                              0x40, 0x40, 0x18, 0x18, 0x18, 0x18, 0x3f, 0x3f,
-                              0x24, 0x24, 0x28, 0x28, 0x01, 0x00, 0x01, 0x00,
-                              0x03, 0x02, 0x03, 0x02, 0x31, 0x31, 0x31, 0x31,
-                              0x30, 0x30, 0x30, 0x30, 0x2f, 0x2f, 0x2f, 0x2f);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP3,
-                              0xaa, 0xea, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0xea,
-                              0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0xea, 0xab, 0xaa,
-                              0xaa, 0xaa, 0xaa, 0xea, 0xab, 0xaa, 0xaa, 0xaa);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x01);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP3,
-                              0xaa, 0x2e, 0x28, 0x00, 0x00, 0x00, 0xaa, 0x2e,
-                              0x28, 0x00, 0x00, 0x00, 0xaa, 0xee, 0xaa, 0xaa,
-                              0xaa, 0xaa, 0xaa, 0xee, 0xaa, 0xaa, 0xaa, 0xaa);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x02);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP3,
-                              0xaa, 0xff, 0xff, 0xff, 0xff, 0xff, 0xaa, 0xff,
-                              0xff, 0xff, 0xff, 0xff);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x03);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETGIP3,
-                              0xaa, 0xaa, 0xea, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa,
-                              0xea, 0xaa, 0xaa, 0xaa, 0xaa, 0xff, 0xff, 0xff,
-                              0xff, 0xff, 0xaa, 0xff, 0xff, 0xff, 0xff, 0xff);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x00);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETTP1,
-                              0x0e, 0x0e, 0x1e, 0x65, 0x1c, 0x65, 0x00, 0x50,
-                              0x20, 0x20, 0x00, 0x00, 0x02, 0x02, 0x02, 0x05,
-                              0x14, 0x14, 0x32, 0xb9, 0x23, 0xb9, 0x08);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x01);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETTP1,
-                              0x02, 0x00, 0xa8, 0x01, 0xa8, 0x0d, 0xa4, 0x0e);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x02);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETTP1,
-                              0x00, 0x00, 0x08, 0x00, 0x01, 0x00, 0x00, 0x00,
-                              0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-                              0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x00,
-                              0x00, 0x00, 0x00, 0x02, 0x00);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETBANK, 0x00);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_UNKNOWN1, 0xc3);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETCLOCK, 0xd1, 0xd6);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_UNKNOWN1, 0x3f);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_UNKNOWN1, 0xc6);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_SETPTBA, 0x37);
-       mipi_dsi_dcs_write_seq(dsi, HX83112A_UNKNOWN1, 0x3f);
-
-       ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
-       if (ret < 0) {
-               dev_err(dev, "Failed to exit sleep mode: %d\n", ret);
-               return ret;
-       }
-       msleep(150);
-
-       ret = mipi_dsi_dcs_set_display_on(dsi);
-       if (ret < 0) {
-               dev_err(dev, "Failed to set display on: %d\n", ret);
-               return ret;
-       }
-       msleep(50);
-
-       return 0;
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETEXTC, 0x83, 0x11, 
0x2a);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETPOWER1,
+                                    0x08, 0x28, 0x28, 0x83, 0x83, 0x4c, 0x4f, 
0x33);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETDISP,
+                                    0x00, 0x02, 0x00, 0x90, 0x24, 0x00, 0x08, 
0x19,
+                                    0xea, 0x11, 0x11, 0x00, 0x11, 0xa3);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETDRV,
+                                    0x58, 0x68, 0x58, 0x68, 0x0f, 0xef, 0x0b, 
0xc0,
+                                    0x0b, 0xc0, 0x0b, 0xc0, 0x00, 0xff, 0x00, 
0xff,
+                                    0x00, 0x00, 0x14, 0x15, 0x00, 0x29, 0x11, 
0x07,
+                                    0x12, 0x00, 0x29);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x02);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETDRV,
+                                    0x00, 0x12, 0x12, 0x11, 0x88, 0x12, 0x12, 
0x00,
+                                    0x53);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x00);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x03);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETDGCLUT,
+                                    0xff, 0xfe, 0xfb, 0xf8, 0xf4, 0xf1, 0xed, 
0xe6,
+                                    0xe2, 0xde, 0xdb, 0xd6, 0xd3, 0xcf, 0xca, 
0xc6,
+                                    0xc2, 0xbe, 0xb9, 0xb0, 0xa7, 0x9e, 0x96, 
0x8d,
+                                    0x84, 0x7c, 0x74, 0x6b, 0x62, 0x5a, 0x51, 
0x49,
+                                    0x41, 0x39, 0x31, 0x29, 0x21, 0x19, 0x12, 
0x0a,
+                                    0x06, 0x05, 0x02, 0x01, 0x00, 0x00, 0xc9, 
0xb3,
+                                    0x08, 0x0e, 0xf2, 0xe1, 0x59, 0xf4, 0x22, 
0xad,
+                                    0x40);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x02);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETDGCLUT,
+                                    0xff, 0xfe, 0xfb, 0xf8, 0xf4, 0xf1, 0xed, 
0xe6,
+                                    0xe2, 0xde, 0xdb, 0xd6, 0xd3, 0xcf, 0xca, 
0xc6,
+                                    0xc2, 0xbe, 0xb9, 0xb0, 0xa7, 0x9e, 0x96, 
0x8d,
+                                    0x84, 0x7c, 0x74, 0x6b, 0x62, 0x5a, 0x51, 
0x49,
+                                    0x41, 0x39, 0x31, 0x29, 0x21, 0x19, 0x12, 
0x0a,
+                                    0x06, 0x05, 0x02, 0x01, 0x00, 0x00, 0xc9, 
0xb3,
+                                    0x08, 0x0e, 0xf2, 0xe1, 0x59, 0xf4, 0x22, 
0xad,
+                                    0x40);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x01);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETDGCLUT,
+                                    0xff, 0xfe, 0xfb, 0xf8, 0xf4, 0xf1, 0xed, 
0xe6,
+                                    0xe2, 0xde, 0xdb, 0xd6, 0xd3, 0xcf, 0xca, 
0xc6,
+                                    0xc2, 0xbe, 0xb9, 0xb0, 0xa7, 0x9e, 0x96, 
0x8d,
+                                    0x84, 0x7c, 0x74, 0x6b, 0x62, 0x5a, 0x51, 
0x49,
+                                    0x41, 0x39, 0x31, 0x29, 0x21, 0x19, 0x12, 
0x0a,
+                                    0x06, 0x05, 0x02, 0x01, 0x00, 0x00, 0xc9, 
0xb3,
+                                    0x08, 0x0e, 0xf2, 0xe1, 0x59, 0xf4, 0x22, 
0xad,
+                                    0x40);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x00);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETDGCLUT, 0x01);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETTCON,
+                                    0x70, 0x00, 0x04, 0xe0, 0x33, 0x00);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETPANEL, 0x08);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETPOWER2, 0x2b, 0x2b);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP0,
+                                    0x80, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 
0x08,
+                                    0x08, 0x03, 0x03, 0x22, 0x18, 0x07, 0x07, 
0x07,
+                                    0x07, 0x32, 0x10, 0x06, 0x00, 0x06, 0x32, 
0x10,
+                                    0x07, 0x00, 0x07, 0x32, 0x19, 0x31, 0x09, 
0x31,
+                                    0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x00, 
0x08,
+                                    0x09, 0x30, 0x00, 0x00, 0x00, 0x06, 0x0d, 
0x00,
+                                    0x0f);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x01);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP0,
+                                    0x00, 0x00, 0x19, 0x10, 0x00, 0x0a, 0x00, 
0x81);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x00);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP1,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 
0x18,
+                                    0xc0, 0xc0, 0x18, 0x18, 0x19, 0x19, 0x18, 
0x18,
+                                    0x40, 0x40, 0x18, 0x18, 0x18, 0x18, 0x3f, 
0x3f,
+                                    0x28, 0x28, 0x24, 0x24, 0x02, 0x03, 0x02, 
0x03,
+                                    0x00, 0x01, 0x00, 0x01, 0x31, 0x31, 0x31, 
0x31,
+                                    0x30, 0x30, 0x30, 0x30, 0x2f, 0x2f, 0x2f, 
0x2f);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP2,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 
0x18,
+                                    0x40, 0x40, 0x18, 0x18, 0x18, 0x18, 0x19, 
0x19,
+                                    0x40, 0x40, 0x18, 0x18, 0x18, 0x18, 0x3f, 
0x3f,
+                                    0x24, 0x24, 0x28, 0x28, 0x01, 0x00, 0x01, 
0x00,
+                                    0x03, 0x02, 0x03, 0x02, 0x31, 0x31, 0x31, 
0x31,
+                                    0x30, 0x30, 0x30, 0x30, 0x2f, 0x2f, 0x2f, 
0x2f);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP3,
+                                    0xaa, 0xea, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 
0xea,
+                                    0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0xea, 0xab, 
0xaa,
+                                    0xaa, 0xaa, 0xaa, 0xea, 0xab, 0xaa, 0xaa, 
0xaa);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x01);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP3,
+                                    0xaa, 0x2e, 0x28, 0x00, 0x00, 0x00, 0xaa, 
0x2e,
+                                    0x28, 0x00, 0x00, 0x00, 0xaa, 0xee, 0xaa, 
0xaa,
+                                    0xaa, 0xaa, 0xaa, 0xee, 0xaa, 0xaa, 0xaa, 
0xaa);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x02);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP3,
+                                    0xaa, 0xff, 0xff, 0xff, 0xff, 0xff, 0xaa, 
0xff,
+                                    0xff, 0xff, 0xff, 0xff);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x03);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETGIP3,
+                                    0xaa, 0xaa, 0xea, 0xaa, 0xaa, 0xaa, 0xaa, 
0xaa,
+                                    0xea, 0xaa, 0xaa, 0xaa, 0xaa, 0xff, 0xff, 
0xff,
+                                    0xff, 0xff, 0xaa, 0xff, 0xff, 0xff, 0xff, 
0xff);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x00);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETTP1,
+                                    0x0e, 0x0e, 0x1e, 0x65, 0x1c, 0x65, 0x00, 
0x50,
+                                    0x20, 0x20, 0x00, 0x00, 0x02, 0x02, 0x02, 
0x05,
+                                    0x14, 0x14, 0x32, 0xb9, 0x23, 0xb9, 0x08);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x01);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETTP1,
+                                    0x02, 0x00, 0xa8, 0x01, 0xa8, 0x0d, 0xa4, 
0x0e);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x02);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETTP1,
+                                    0x00, 0x00, 0x08, 0x00, 0x01, 0x00, 0x00, 
0x00,
+                                    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 
0x00,
+                                    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 
0x00,
+                                    0x00, 0x00, 0x00, 0x02, 0x00);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETBANK, 0x00);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_UNKNOWN1, 0xc3);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETCLOCK, 0xd1, 0xd6);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_UNKNOWN1, 0x3f);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_UNKNOWN1, 0xc6);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_SETPTBA, 0x37);
+       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83112A_UNKNOWN1, 0x3f);
+
+       mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
+       mipi_dsi_msleep(&dsi_ctx, 150);
+
+       mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
+       mipi_dsi_msleep(&dsi_ctx, 50);
+
+       return dsi_ctx.accum_err;
  }
static int hx83112a_disable(struct drm_panel *panel)
  {
        struct hx83112a_panel *ctx = to_hx83112a_panel(panel);
        struct mipi_dsi_device *dsi = ctx->dsi;
-       struct device *dev = &dsi->dev;
-       int ret;
+       struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; - ret = mipi_dsi_dcs_set_display_off(dsi);
-       if (ret < 0) {
-               dev_err(dev, "Failed to set display off: %d\n", ret);
-               return ret;
-       }
-       msleep(20);
-
-       ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
-       if (ret < 0) {
-               dev_err(dev, "Failed to enter sleep mode: %d\n", ret);
-               return ret;
-       }
-       msleep(120);
+       mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
+       mipi_dsi_msleep(&dsi_ctx, 20);
+       mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
+       mipi_dsi_msleep(&dsi_ctx, 120);
- return 0;
+       return dsi_ctx.accum_err;
  }
static int hx83112a_prepare(struct drm_panel *panel)
  {
        struct hx83112a_panel *ctx = to_hx83112a_panel(panel);
-       struct device *dev = &ctx->dsi->dev;
        int ret;
ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
-       if (ret < 0) {
-               dev_err(dev, "Failed to enable regulators: %d\n", ret);
+       if (ret < 0)
                return ret;
-       }
hx83112a_reset(ctx); - ret = hx83112a_on(ctx);
+       ret = hx83112a_on(ctx->dsi);
        if (ret < 0) {
-               dev_err(dev, "Failed to initialize panel: %d\n", ret);
                gpiod_set_value_cansleep(ctx->reset_gpio, 1);
                regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), 
ctx->supplies);
-               return ret;
        }
- return 0;
+       return ret;
  }
static int hx83112a_unprepare(struct drm_panel *panel)
--
2.46.0

Reply via email to