On 4/9/25 6:13 PM, Maxime Ripard wrote: > On Wed, Mar 26, 2025 at 12:19:58PM +0200, Cristian Ciocaltea wrote: >> Rename the reject_100_MHz_connector_hdmi_funcs variable to make >> checkpatch.pl happy: >> >> CHECK: Avoid CamelCase: <reject_100_MHz_connector_hdmi_funcs> >> >> While at it, also rename reject_100MHz_connector_tmds_char_rate_valid() >> for consistency. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocal...@collabora.com> > > In this case, checkpatch is wrong. mhz != MHz. > > And since it's not a warning, I'd just ignore it.
I think it also improves consistency a bit, as this is actually the only place where "[_]MHz" is being used in the file, everywhere else we have "mhz", without '_' prefix. But I can still drop the patch if you prefer.
