Hi Maxime,
On 4/9/25 6:02 PM, Maxime Ripard wrote:
> Hi,
>
> On Wed, Mar 26, 2025 at 12:19:55PM +0200, Cristian Ciocaltea wrote:
>> In preparation to support fallback to an alternative output format, e.g.
>> YUV420, when RGB cannot be used for any of the available color depths,
>> move the bpc try loop out of hdmi_compute_config() and, instead, make it
>> part of hdmi_compute_format_bpc(). Additionally, add a new parameter to
>> the latter holding the output format to be checked and eventually set.
>>
>> This improves code reusability and further extensibility.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocal...@collabora.com>
>
> I think patch 5 could be squashed into this one.
Ack.
>> ---
>> drivers/gpu/drm/display/drm_hdmi_state_helper.c | 50
>> ++++++++++++-------------
>> 1 file changed, 23 insertions(+), 27 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c
>> b/drivers/gpu/drm/display/drm_hdmi_state_helper.c
>> index
>> 160964190d82ac233fdbe34ac54024a007a19872..6de0abb15ecb36fd4eb98725e2a3835e5e0db134
>> 100644
>> --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c
>> +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c
>> @@ -608,42 +608,19 @@ static int
>> hdmi_compute_format_bpc(const struct drm_connector *connector,
>> struct drm_connector_state *conn_state,
>> const struct drm_display_mode *mode,
>> - unsigned int bpc)
>> + unsigned int max_bpc, enum hdmi_colorspace fmt)
>> {
>> struct drm_device *dev = connector->dev;
>> -
>> - /*
>> - * TODO: Add support for YCbCr420 output for HDMI 2.0 capable
>> - * devices, for modes that only support YCbCr420.
>> - */
>
> And we should fix that comment for now.
Sorry, I missed to move this hunk to the next patch.
>
> Once fixed,
> Reviewed-by: Maxime Ripard <mrip...@kernel.org>
Thanks,
Cristian
