On 4/29/25 13:34, Ian Forbes wrote:
> Running 3D applications with SVGA_FORCE_HOST_BACKED=1 or using an
> ancient version of mesa was broken because the buffer was pinned in
> VMW_BO_DOMAIN_SYS and could not be moved to VMW_BO_DOMAIN_MOB during
> validation.
>
> The compat_shader buffer should not pinned.
>
> Fixes: 668b206601c5 ("drm/vmwgfx: Stop using raw ttm_buffer_object's")
> Signed-off-by: Ian Forbes <ian.for...@broadcom.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_shader.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> index 7fb1c88bcc47..69dfe69ce0f8 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
> @@ -896,7 +896,7 @@ int vmw_compat_shader_add(struct vmw_private *dev_priv,
> .busy_domain = VMW_BO_DOMAIN_SYS,
> .bo_type = ttm_bo_type_device,
> .size = size,
> - .pin = true,
> + .pin = false,
> .keep_resv = true,
> };
>
Looks good.
Reviewed-by: Maaz Mombasawala <maaz.mombasaw...@broadcom.com>
--
Maaz Mombasawala <maaz.mombasaw...@broadcom.com>
