On 30/04/2025 15:00, Krzysztof Kozlowski wrote: > > @@ -361,21 +373,46 @@ static int dsi_pll_7nm_lock_status(struct dsi_pll_7nm > *pll) > > static void dsi_pll_disable_pll_bias(struct dsi_pll_7nm *pll) > { > - u32 data = readl(pll->phy->base + REG_DSI_7nm_PHY_CMN_CTRL_0); > + unsigned long flags; > + u32 data; > + > + spin_lock_irqsave(&pll->pll_enable_lock, flags); > + --pll->pll_enable_cnt; > + if (pll->pll_enable_cnt < 0) {
I removed too much from debugging - this should be WARN_ON or dev_err > + spin_unlock_irqrestore(&pll->pll_enable_lock, flags); > + return; > + } else if (pll->pll_enable_cnt > 0) { > + spin_unlock_irqrestore(&pll->pll_enable_lock, flags); > + return; > + } /* else: == 0 */ Best regards, Krzysztof