While the Vivante driver also claims to disable clock gating during reset
(in reality it doesn't because it clears the wrong register and *enables*
clock gating for all modules), it has been shown that switching the clock
gating enable state in the reset sequence has made the GPU reset less
reliable and often leaves parts of the GPU in indeterminate state.

Fixes: b0da08559c74 ("drm/etnaviv: disable MLCG and pulse eater on GPU reset")
Signed-off-by: Lucas Stach <l.st...@pengutronix.de>
---
 drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c 
b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index bf59f4ee0e72..a1e84deba6c0 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -542,9 +542,6 @@ static int etnaviv_hw_reset(struct etnaviv_gpu *gpu)
                unsigned int fscale = 1 << (6 - gpu->freq_scale);
                u32 pulse_eater = 0x01590880;
 
-               /* disable clock gating */
-               gpu_write_power(gpu, VIVS_PM_POWER_CONTROLS, 0x0);
-
                /* disable pulse eater */
                pulse_eater |= BIT(17);
                gpu_write_power(gpu, VIVS_PM_PULSE_EATER, pulse_eater);
-- 
2.39.5

Reply via email to