On Fri, Jun 20, 2025 at 05:31:04PM +0800, Yongbang Shi wrote:
> From: Baihan Li <libai...@huawei.com>
>
> Add colorbar disable operation and move hdcp opreation behind the reset
> controller operation.
Two items => two commits
You missed the 'why' part of the commit message.
>
> Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq
> feature")
> Fixes: 94ee73ee3020 ("drm/hisilicon/hibmc: add dp hw moduel in hibmc driver")
Which one is wrong?
> Signed-off-by: Baihan Li <libai...@huawei.com>
> Signed-off-by: Yongbang Shi <shiyongb...@huawei.com>
> ---
> ChangeLog:
> v1 -> v2:
> - separate the patch, suggested by Dmitry Baryshkov.
> ---
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c
> b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c
> index edb7539d830e..bb19636caf77 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c
> @@ -172,15 +172,17 @@ int hibmc_dp_hw_init(struct hibmc_dp *dp)
> dp_dev->link.cap.lanes = 0x2;
> dp_dev->link.cap.link_rate = DP_LINK_BW_8_1;
>
> - /* hdcp data */
> - writel(HIBMC_DP_HDCP, dp_dev->base + HIBMC_DP_HDCP_CFG);
> /* int init */
> writel(0, dp_dev->base + HIBMC_DP_INTR_ENABLE);
> writel(HIBMC_DP_INT_RST, dp_dev->base + HIBMC_DP_INTR_ORIGINAL_STATUS);
> + /* clr colorbar */
> + writel(0, dp_dev->base + HIBMC_DP_COLOR_BAR_CTRL);
> /* rst */
> writel(0, dp_dev->base + HIBMC_DP_DPTX_RST_CTRL);
> usleep_range(30, 50);
> writel(HIBMC_DP_DPTX_RST, dp_dev->base + HIBMC_DP_DPTX_RST_CTRL);
> + /* hdcp data */
> + writel(HIBMC_DP_HDCP, dp_dev->base + HIBMC_DP_HDCP_CFG);
> /* clock enable */
> writel(HIBMC_DP_CLK_EN, dp_dev->base + HIBMC_DP_DPTX_CLK_CTRL);
>
> --
> 2.33.0
>
--
With best wishes
Dmitry
