On Thu, Jun 26, 2025 at 06:23:13PM +0200, Beata Michalska wrote: > With the Opaque<T>, the expectations are that Rust should not > make any assumptions on the layout or invariants of the wrapped > C types. That runs rather counter to ioctl arguments, which must > adhere to certain data-layout constraints. By using Opaque<T>, > ioctl handlers are forced to use unsafe code where none is actually > needed. This adds needless complexity and maintenance overhead, > brining no safety benefits. > Drop the use of Opaque for ioctl arguments as that is not the best > fit here. > > Signed-off-by: Beata Michalska <beata.michal...@arm.com> > Acked-by: Danilo Krummrich <d...@kernel.org> > Reviewed-by: Boqun Feng <boqun.f...@gmail.com>
I'm guessing this should go through the DRM tree? Reviewed-by: Alice Ryhl <alicer...@google.com>