> On 21 Jul 2025, at 12:33, Danilo Krummrich <d...@kernel.org> wrote:
>
> On Thu Jun 26, 2025 at 6:23 PM CEST, Beata Michalska wrote:
>> With the Opaque<T>, the expectations are that Rust should not
>> make any assumptions on the layout or invariants of the wrapped
>> C types. That runs rather counter to ioctl arguments, which must
>> adhere to certain data-layout constraints. By using Opaque<T>,
>> ioctl handlers are forced to use unsafe code where none is actually
>> needed. This adds needless complexity and maintenance overhead,
>> brining no safety benefits.
>> Drop the use of Opaque for ioctl arguments as that is not the best
>> fit here.
>>
>> Signed-off-by: Beata Michalska <beata.michal...@arm.com>
>> Acked-by: Danilo Krummrich <d...@kernel.org>
>> Reviewed-by: Boqun Feng <boqun.f...@gmail.com>
>
> The patch does not apply on top of drm-misc-next and does not have a base
> revision.
>
> Can you please let me know which commit this patch applies on top of or
> resend?
>
> - Danilo
I applied this locally on top of nova-next. Nova still builds, but I don’t
have the hardware to test.
— Daniel
