On Mon, Aug 11, 2025 at 02:57:00PM +0530, Suraj Kandpal wrote:
> Some drivers cannot work with the current design where the connector
> is embedded within the drm_writeback_connector such as intel and
> some drivers that can get it working end up adding a lot of checks
> all around the code to check if it's a writeback conenctor or not.
> To solve this we move the drm_writeback_connector within the
> drm_connector and remove the drm_connector base which was in
> drm_writeback_connector. We do all other required
> modifications that come with these changes along with addition
> of new function which returns the drm_connector when
> drm_writeback_connector is present.
> All drivers will be expected to allocate the drm_connector.
>
> Signed-off-by: Suraj Kandpal <suraj.kand...@intel.com>
> ---
> drivers/gpu/drm/drm_writeback.c | 33 ++++++++++------
> include/drm/drm_connector.h | 60 +++++++++++++++++++++++++++++
> include/drm/drm_writeback.h | 68 ++++-----------------------------
> 3 files changed, 89 insertions(+), 72 deletions(-)
This patch breaks building of drivers:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c: In function
‘dpu_encoder_phys_wb_prepare_for_kickoff’:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:487:36: error: ‘struct
drm_writeback_connector’ has no member named ‘base’
487 | drm_conn = &wb_enc->wb_conn->base;
| ^~
Please perform step-by-step modifications, making sure that on each
step all the drivers can be built and function as expected.
>
> @@ -2305,6 +2360,11 @@ struct drm_connector {
> * @cec: CEC-related data.
> */
> struct drm_connector_cec cec;
> +
> + /**
> + * @writeback: Writeback related valriables.
> + */
> + struct drm_writeback_connector writeback;
I will respond to this in another thread.
> };
>
> #define obj_to_connector(x) container_of(x, struct drm_connector, base)
--
With best wishes
Dmitry
