> 
> This patch breaks building of drivers:
> 
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c: In function
> ‘dpu_encoder_phys_wb_prepare_for_kickoff’:
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:487:36: error:
> ‘struct drm_writeback_connector’ has no member named ‘base’
>   487 |         drm_conn = &wb_enc->wb_conn->base;
>       |                                    ^~
> 
> Please perform step-by-step modifications, making sure that on each step all
> the drivers can be built and function as expected.

Yes I am aware of that currently sent this series out like this for the reason 
that all drivers
can see all the changes that come in the same patch and comment if they want it 
done a particular
way.
Otherwise I end up having to make patches with all the driver patches in the 
same patches.
Anyways when I send a more final version of these patches I'll have it done 
that way.

Regards,
Suraj Kandpal

> 
> >
> > @@ -2305,6 +2360,11 @@ struct drm_connector {
> >      * @cec: CEC-related data.
> >      */
> >     struct drm_connector_cec cec;
> > +
> > +   /**
> > +    * @writeback: Writeback related valriables.
> > +    */
> > +   struct drm_writeback_connector writeback;
> 
> I will respond to this in another thread.
> 
> >  };
> >
> >  #define obj_to_connector(x) container_of(x, struct drm_connector,
> > base)
> 
> --
> With best wishes
> Dmitry

Reply via email to