On Wed, Aug 20, 2025 at 05:34:51PM +0800, Xiangxu Yin wrote:
> Define qmp_usbc_dp_phy_ops struct to support DP mode on USB/DP
> switchable PHYs.
>
> Signed-off-by: Xiangxu Yin <xiangxu....@oss.qualcomm.com>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 163
> +++++++++++++++++++++++++++++++
> 1 file changed, 163 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> index
> 1508a4a5f57aff85318485b79528325f28a825a4..a1495a2029cf038bb65c36e42d0a4f633e544558
> 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
> @@ -22,6 +22,8 @@
> #include <linux/slab.h>
> #include <linux/usb/typec.h>
> #include <linux/usb/typec_mux.h>
> +#include <dt-bindings/phy/phy-qcom-qmp.h>
> +#include <drm/bridge/aux-bridge.h>
This one is not necessary yet
>
> #include "phy-qcom-qmp-common.h"
>
[...]
> static const struct phy_ops qmp_usbc_usb_phy_ops = {
> .init = qmp_usbc_usb_enable,
> .exit = qmp_usbc_usb_disable,
> @@ -1095,6 +1248,16 @@ static const struct phy_ops qmp_usbc_usb_phy_ops = {
> .owner = THIS_MODULE,
> };
>
> +static const struct phy_ops qmp_usbc_dp_phy_ops = {
Please try restructuring your patches so that there are no unused
warnings in the middle of the series. You can split the next patch into
'parse' and 'enable' parts, then squash this patch into the 'enable'
one.
> + .init = qmp_usbc_dp_enable,
> + .exit = qmp_usbc_dp_disable,
> + .configure = qmp_usbc_dp_configure,
> + .calibrate = qmp_usbc_dp_calibrate,
> + .power_on = qmp_usbc_dp_power_on,
> + .power_off = qmp_usbc_dp_power_off,
> + .owner = THIS_MODULE,
> +};
> +
> static void qmp_usbc_enable_autonomous_mode(struct qmp_usbc *qmp)
> {
> const struct qmp_phy_cfg *cfg = qmp->cfg;
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
