On Wed, Aug 27, 2025 at 08:17:39PM +0800, Xiangxu Yin wrote:
>
> On 8/20/2025 7:45 PM, Dmitry Baryshkov wrote:
> > On Wed, Aug 20, 2025 at 05:34:51PM +0800, Xiangxu Yin wrote:
> >> Define qmp_usbc_dp_phy_ops struct to support DP mode on USB/DP
> >> switchable PHYs.
> >>
> >> Signed-off-by: Xiangxu Yin <xiangxu....@oss.qualcomm.com>
> >> ---
> >> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 163
> >> +++++++++++++++++++++++++++++++
> >> 1 file changed, 163 insertions(+)
> >>
> >> @@ -1095,6 +1248,16 @@ static const struct phy_ops qmp_usbc_usb_phy_ops = {
> >> .owner = THIS_MODULE,
> >> };
> >>
> >> +static const struct phy_ops qmp_usbc_dp_phy_ops = {
> > Please try restructuring your patches so that there are no unused
> > warnings in the middle of the series. You can split the next patch into
> > 'parse' and 'enable' parts, then squash this patch into the 'enable'
> > one.
>
>
> You mean it's better to define and register new functions in the same patch
>
> where they're first used, to avoid unused warnings? And for things like
> parse_dt and phy_ops,
>
> it's fine to split them into separate patches if each part is used right away?
Yes.
>
>
> >
> >> + .init = qmp_usbc_dp_enable,
> >> + .exit = qmp_usbc_dp_disable,
> >> + .configure = qmp_usbc_dp_configure,
> >> + .calibrate = qmp_usbc_dp_calibrate,
> >> + .power_on = qmp_usbc_dp_power_on,
> >> + .power_off = qmp_usbc_dp_power_off,
> >> + .owner = THIS_MODULE,
> >> +};
> >> +
> >> static void qmp_usbc_enable_autonomous_mode(struct qmp_usbc *qmp)
> >> {
> >> const struct qmp_phy_cfg *cfg = qmp->cfg;
> >>
> >> --
> >> 2.34.1
> >>
--
With best wishes
Dmitry
