Hi Maxime, On Tue, Sep 02, 2025 at 11:35:16AM +0200, Maxime Ripard wrote: > The imx-dcss atomic_check implementation uses the deprecated > drm_atomic_get_existing_crtc_state() helper. > > This hook is called as part of the global atomic_check, thus before the > states are swapped. The existing state thus points to the new state, and > we can use drm_atomic_get_new_crtc_state() instead. > > Signed-off-by: Maxime Ripard <mrip...@kernel.org>
Reviewed-by: Laurentiu Palcu <laurentiu.pa...@oss.nxp.com> Thanks, Laurentiu > > --- > To: Laurentiu Palcu <laurentiu.pa...@oss.nxp.com> > To: Shawn Guo <shawn...@kernel.org> > To: Sascha Hauer <s.ha...@pengutronix.de> > Cc: Lucas Stach <l.st...@pengutronix.de> > Cc: Pengutronix Kernel Team <ker...@pengutronix.de> > Cc: Fabio Estevam <feste...@gmail.com> > Cc: dri-devel@lists.freedesktop.org > Cc: i...@lists.linux.dev > Cc: linux-arm-ker...@lists.infradead.org > --- > drivers/gpu/drm/imx/dcss/dcss-plane.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c > b/drivers/gpu/drm/imx/dcss/dcss-plane.c > index > ab6d32bad756d080e1c56d7574403febceff94f4..3a063a53c8dfa6bc5bbbf9afc7ff6519199c2f19 > 100644 > --- a/drivers/gpu/drm/imx/dcss/dcss-plane.c > +++ b/drivers/gpu/drm/imx/dcss/dcss-plane.c > @@ -157,12 +157,12 @@ static int dcss_plane_atomic_check(struct drm_plane > *plane, > return 0; > > dma_obj = drm_fb_dma_get_gem_obj(fb, 0); > WARN_ON(!dma_obj); > > - crtc_state = drm_atomic_get_existing_crtc_state(state, > - new_plane_state->crtc); > + crtc_state = drm_atomic_get_new_crtc_state(state, > + new_plane_state->crtc); > > hdisplay = crtc_state->adjusted_mode.hdisplay; > vdisplay = crtc_state->adjusted_mode.vdisplay; > > if (!dcss_plane_is_source_size_allowed(new_plane_state->src_w >> 16, > > -- > 2.50.1 >
