On 9/12/2025 4:46 PM, Konrad Dybcio wrote: > On 9/12/25 4:15 AM, Xiangxu Yin wrote: >> On 9/12/2025 9:24 AM, Dmitry Baryshkov wrote: >>> On Thu, Sep 11, 2025 at 10:55:01PM +0800, Xiangxu Yin wrote: >>>> Introduce QCS615 hardware-specific configuration for DP PHY mode, >>>> including register offsets, initialization tables, voltage swing >>>> and pre-emphasis settings. >>>> >>>> Add qcs615-qmp-usb3-dp-phy compatible string to associate QCS615 >>>> platform with its USB/DP switchable PHY configuration. >>> This should be the last patch in the series: once you add the compatible >>> string, it is expected that it works. >>> >>> The patch LGTM. >> >> In v3[12/14], the compatible string was placed in the last, and you remind me >> will trigger unused warnings for the earlier-defined qcs615_usb3dp_phy_cfg. >> So I merged them in v4. > The intention is that you can do all the preparing first (which doesn't need > to include an assignment to e.g. DP tables, since the code operates on a > pointer if it's non-null), and you can push all the platform additions at the > end (both tables and compatible in one patch) > > Konrad
Ok, then merging 04 and 07 with the compatible in the last patch looks appropriate, will update in next patch. >> If move this patch to the end, patch v4[07/13] will hit unused warnings due >> to >> missing references. Should I squash patches 04 & 07 and move them to the end? >> I'm concerned the resulting patch might be too large. >> >> >>>> Signed-off-by: Xiangxu Yin <xiangxu....@oss.qualcomm.com> >>>> --- >>>> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 141 >>>> +++++++++++++++++++++++++++++++ >>>> 1 file changed, 141 insertions(+) >>>>
