On Tue, Sep 30, 2025 at 11:18:15AM +0530, Akhil P Oommen wrote: > GMU registers are always at a fixed offset from the GPU base address, > a consistency maintained at least within a given architecture generation. > In A8x family, the base address of the GMU has changed, but the offsets > of the gmu registers remain largely the same. To enable reuse of the gmu
I understand the code, but I think I'd very much prefer to see it in the catalog file (with the note on how to calculate it). Reading resources for two different devices sounds too strange to be nice. This way you can keep the offsets for a6xx / a7xx untouched and just add the non-zero offset for a8xx. > code for A8x chipsets, update the gmu register offsets to be relative > to the GPU's base address instead of GMU's. > > Signed-off-by: Akhil P Oommen <[email protected]> > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 44 +++- > drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 20 +- > drivers/gpu/drm/msm/registers/adreno/a6xx_gmu.xml | 248 > +++++++++++----------- > 3 files changed, 172 insertions(+), 140 deletions(-) -- With best wishes Dmitry
