Using this operand can produce invalid values. It also doesn't bring any benefit as one can use the builder pattern to assemble a new value.
Reported-by: Edwin Peer <[email protected]> Link: https://lore.kernel.org/rust-for-linux/[email protected]/ Signed-off-by: Alexandre Courbot <[email protected]> --- drivers/gpu/nova-core/bitfield.rs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/nova-core/bitfield.rs b/drivers/gpu/nova-core/bitfield.rs index f113439c6501..16e143658c51 100644 --- a/drivers/gpu/nova-core/bitfield.rs +++ b/drivers/gpu/nova-core/bitfield.rs @@ -94,7 +94,7 @@ macro_rules! bitfield { // All rules below are helpers. // Defines the wrapper `$name` type, as well as its relevant implementations (`Debug`, - // `Default`, `BitOr`, and conversion to the value type) and field accessor methods. + // `Default`, and conversion to the value type) and field accessor methods. (@core $vis:vis $name:ident $storage:ty $(, $comment:literal)? { $($fields:tt)* }) => { $( #[doc=$comment] @@ -103,14 +103,6 @@ macro_rules! bitfield { #[derive(Clone, Copy)] $vis struct $name($storage); - impl ::core::ops::BitOr for $name { - type Output = Self; - - fn bitor(self, rhs: Self) -> Self::Output { - Self(self.0 | rhs.0) - } - } - impl ::core::convert::From<$name> for $storage { fn from(val: $name) -> $storage { val.0 -- 2.51.0
