On 10/22/2025 6:50 AM, Alexandre Courbot wrote:
> This condition was uselessly convoluted.
>
> Reported-by: Edwin Peer <[email protected]>
> Link:
> https://lore.kernel.org/rust-for-linux/[email protected]/
> Signed-off-by: Alexandre Courbot <[email protected]>
Reviewed-by: Joel Fernandes <[email protected]>
Thanks.
> ---
> drivers/gpu/nova-core/bitfield.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/bitfield.rs
> b/drivers/gpu/nova-core/bitfield.rs
> index 25579b4c328f..136de7289162 100644
> --- a/drivers/gpu/nova-core/bitfield.rs
> +++ b/drivers/gpu/nova-core/bitfield.rs
> @@ -203,7 +203,7 @@ impl $name {
> ) => {
> bitfield!(
> @leaf_accessor $vis $name $storage, $hi:$lo $field
> - { |f| <$into_type>::from(if f != 0 { true } else { false }) }
> + { |f| <$into_type>::from(f != 0) }
> bool $into_type => $into_type $(, $comment)?;
> );
> };
>
