On 10/22/25 12:16 PM, Mohamed Ahmed wrote: > Pinging again re: review and also was asking if we can revert the > select_page_shift() handling back to v1 behavior with a fall-back > path, as it looks like there are some cases where > nouveau_bo_fixup_align() isn't enough; > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36450#note_3159199.
I don't think we should add a fallback for something that is expected to be sufficient. Instead we should figure out in which exact case the WARN_ON() was hit and why.
