On Wed, Oct 22, 2025 at 10:56 PM Danilo Krummrich <[email protected]> wrote: > > On 10/22/25 12:16 PM, Mohamed Ahmed wrote: > > Pinging again re: review and also was asking if we can revert the > > select_page_shift() handling back to v1 behavior with a fall-back > > path, as it looks like there are some cases where > > nouveau_bo_fixup_align() isn't enough; > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36450#note_3159199. > > I don't think we should add a fallback for something that is expected to be > sufficient. > > Instead we should figure out in which exact case the WARN_ON() was hit and > why.
The reason I wrote this code initially was to handle addresses provided by userspace that aren't aligned to the page size selected during BO creation. This is something I did trigger when typing this patch initially with my distro provided version of mesa (likely 25.0.x but it has been a while) Thomas Andersen also confirmed on nouveau irc channel that he did hit this case with an old version of NVK and this patchset. I think we could just remove the WARN_ON and properly document that this was previously allowed and is there for backward compatibility. Regards, Mary Guillemard
