On 10/30/25 08:50, Louis Chauvet wrote:
This patch LGTM, but can you add the [1] (preparatory patch to reduce
the diff in this patch) and [2] (fixup to this patch, add a module
parameter to enable/disable the pipeline and disable it by default for
configfs devices) so it will make it easier to implement configfs for
color pipeline without breaking uAPI?
[1]:https://paste.sr.ht/~fomys/16118ef2b5604226a7607db8a41941a27a43f168
[2]:https://paste.sr.ht/~fomys/a98191b09ff7290dc6768bf7d54e789984cd3250
With those patches: Reviewed-by: Louis Chauvet <[email protected]>
Thanks a lot for your series!
Hi Louis,
Thanks for reviewing.
Do you want to add these patch on top of this patch as below?
e1c34c68dc33 fixup! drm/vkms: Add enumerated 1D curve colorop
68251534ebd1 drm/vkms: Pass plane_cfg to plane initialization
8160438be2b5 drm/vkms: Add enumerated 1D curve colorop
I noticed "fixup! drm/vkms: Add enumerated 1D curve colorop" has no
commit messages though.
Or do you prefer them to squash them together?
