Re: [PATCH V12 14/49] drm/vkms: Add enumerated 1D curve colorop

[Alex Hung]

On 10/31/25 04:15, Louis Chauvet wrote:

Hi Louis,

Thanks for reviewing.

Do you want to add these patch on top of this patch as below?

    e1c34c68dc33 fixup! drm/vkms: Add enumerated 1D curve colorop
    68251534ebd1 drm/vkms: Pass plane_cfg to plane initialization
    8160438be2b5 drm/vkms: Add enumerated 1D curve colorop

I noticed "fixup! drm/vkms: Add enumerated 1D curve colorop" has no
commit messages though.

drm/vkms: Add config for default plane pipeline

With the introduction of color pipeline in VKMS, the default device may 
have planes with color pipelines. To avoid breaking existing uAPI, 
create a kernel argument to disable them by default and a vkms_config 
field to configure the plane.

This field is not definitive and will be replaced once the uAPI will be 
able to configure color pipelines. For now devices created with ConfigFS 
will not have any color pipeline so we can decide later how the uAPI 
will look like.

Thanks.


Or do you prefer them to squash them together?

For me 68251534ebd1 is independent so keep it separate.

But for e1c34c68dc33 I don't think this is important to squash or keep 
them separate. You can do as you want.

If you want to split it, I think you can put e1c34c68dc33 before 
8160438be2b5 so you don't have to change the call to 
vkms_initialize_colorops(&plane->base);.


vkms_initialize_colorops is introduced in 8160438be2b5so and thus 
e1c34c68dc33 need to stay after it. I think it's a minor change so let's 
not move the function vkms_initialize_colorops() from one patch to another.

The patch order looks like the following.

e1c34c68dc33 drm/vkms: Add config for default plane pipeline
8160438be2b5 drm/vkms: Add enumerated 1D curve colorop
68251534ebd1 drm/vkms: Pass plane_cfg to plane initialization


Thanks a lot,
Louis Chauvet