On Tue, Nov 18, 2025 at 2:54 PM Tomi Valkeinen <[email protected]> wrote:
> The questions I have: > > - Should we 1) keep the current upstream sequence as default, and > specific drivers can opt to use new helpers that make sure the crtc is > enabled early (like your patch), or 2) revert the sequence changes from > Aradhya, restoring the crtc-enabled-first style, and add new helpers > that handle the sequence in the new way, as it is currently in upstream. I'm opting toward (1) given that: - The new sequence order is natural, a sensible default - Only mine and Mareks systems appear to be affected despite the patch has been upstream for a while. > - These patches only deal with the enable side. Disable side was also > changed in Aradhya's patch. I guess that has not been a problem, but it > worries me a bit if the enable and disable sequences are not mirroring > each other. I imagine we can do the same for the reverse side, by splitting .disable_outputs() in disable_outputs() and disable_outputs_late() that will disable the CRTC last like before the regressing patch. I'm cooking a new patch series, just a sec. Yours, Linus Walleij
