On Tue, Nov 18, 2025 at 5:47 PM Marek Vasut <[email protected]> wrote: > On 11/18/25 3:31 PM, Linus Walleij wrote: > > On Tue, Nov 18, 2025 at 2:54 PM Tomi Valkeinen > > <[email protected]> wrote: > > > >> The questions I have: > >> > >> - Should we 1) keep the current upstream sequence as default, and > >> specific drivers can opt to use new helpers that make sure the crtc is > >> enabled early (like your patch), or 2) revert the sequence changes from > >> Aradhya, restoring the crtc-enabled-first style, and add new helpers > >> that handle the sequence in the new way, as it is currently in upstream. > > > > I'm opting toward (1) given that: > > > > - The new sequence order is natural, a sensible default > > > > - Only mine and Mareks systems appear to be affected despite the > > patch has been upstream for a while.
> I might have had a revert in tree for a while, revert which I forgot > about, sorry. If it's just you and me that have a problem with this commit it's fine I guess, we can just fix our drivers. I am worried that since the new behaviour has been in v6.17 there might already be new code that implicitly depends on it and will have visible regressions (such as flicker or glitches...) if we just revert the behaviour. Yours, Linus Walleij
