Hi Linus, Thanks for following-up on that
On Fri, Nov 21, 2025 at 03:08:31PM +0100, Linus Walleij wrote: > Export and namespace those not prefixed with drm_* so > it becomes possible to write custom commit tail functions > in individual drivers using the helper infrastructure. > > Signed-off-by: Linus Walleij <[email protected]> > --- > drivers/gpu/drm/drm_atomic_helper.c | 54 > +++++++++++++++++++++---------------- > include/drm/drm_atomic_helper.h | 19 +++++++++++++ > 2 files changed, 50 insertions(+), 23 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index d5ebe6ea0acb..906eb4b0852c 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -1162,8 +1162,8 @@ crtc_needs_disable(struct drm_crtc_state *old_state, > new_state->self_refresh_active; > } > > -static void > -encoder_bridge_disable(struct drm_device *dev, struct drm_atomic_state > *state) > +void > +drm_encoder_bridge_disable(struct drm_device *dev, struct drm_atomic_state > *state) I think the prefix should rather be drm_atomic_helper_commit_* to remain consistent, so drm_atomic_helper_commit_encoder_bridge_disable in this particular case. This applies to the other functions here too, but it looks good to me otherwise. Maxime
signature.asc
Description: PGP signature
