On Fri, Dec 05, 2025 at 04:20:55PM +0100, Maud Spierings wrote: > Thanks for the review. > > On 12/4/25 17:17, Daniel Thompson wrote: > > On Mon, Dec 01, 2025 at 12:53:21PM +0100, Maud Spierings via B4 Relay wrote: > > > The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC > > > with integrated boost controller. > > > > > > Signed-off-by: Maud Spierings <[email protected]> > > <snip> > > > > +static int max25014_update_status(struct backlight_device *bl_dev) > > > +{ > > > + struct max25014 *maxim = bl_get_data(bl_dev); > > > + uint32_t reg; > > > + int ret; > > > + > > > + if (backlight_is_blank(maxim->bl)) > > > + bl_dev->props.brightness = 0; > > > > This isn't right. Why would you change the backlight level just because > > it is currently blanked (and sorry I missed this one last time). > > so just remove this bit then jeah?
Yes. backlight_get_brightness() is all you should need. > > > + > > > + reg = TON_STEP * bl_dev->props.brightness; > > > > The correct way to honour blanking is just go call > > backlight_get_brightness() instead of reading the property directly. > > will do. Thanks. Daniel.
