On Wed, Dec 24, 2025 at 06:26:59PM +0100, Marijn Suijten wrote: > On 2025-12-24 17:33:49, Dmitry Baryshkov wrote: > > From: Teguh Sobirin <[email protected]> > > > > Since DPU 5.x the vsync source TE setup is split between MDP TOP and > > INTF blocks. Currently all code to setup vsync_source is only exectued > > exectued -> executed typo remains since v2. > > > if MDP TOP implements the setup_vsync_source() callback. However on > Double space to match the above, on two occasions: ^^
I've changed all occurences to 1 space. > > > DPU >= 8.x this callback is not implemented, making DPU driver skip all > > vsync setup. Move the INTF part out of this condition, letting DPU > ^^ double space too > > > driver to setup TE vsync selection on all new DPU devices. > > > > Signed-off-by: Teguh Sobirin <[email protected]> > > Fixes: 2f69e5458447 ("drm/msm/dpu: skip watchdog timer programming through > > TOP on >= SM8450") > > [DB: restored top->ops.setup_vsync_source call] > > Signed-off-by: Dmitry Baryshkov <[email protected]> > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 17 +++++++++-------- > > 1 file changed, 9 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > index d1cfe81a3373..0482b2bb5a9e 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > @@ -774,6 +774,9 @@ static void _dpu_encoder_update_vsync_source(struct > > dpu_encoder_virt *dpu_enc, > > return; > > } > > > > + /* Set vsync source irrespective of mdp top support */ > > I still think this comment is redundant, as mentioned in v2. Dropped -- With best wishes Dmitry
