On Wed, Jan 28, 2026 at 02:22:50PM +0800, Shawn Lin wrote: > 在 2026/01/28 星期三 5:53, Neil Armstrong 写道: > > On 1/27/26 16:53, Manivannan Sadhasivam wrote: > > > On Tue, Jan 27, 2026 at 10:57:29AM +0100, Neil Armstrong wrote: > > > > Add support fo the Renesas UPD720201/UPD720202 USB 3.0 xHCI Host > > > > Controller > > > > power control which connects over PCIe and requires specific > > > > power supplies > > > > to start up. > > > > > > > > > > This driver only handles the supplies. So why can't you use the existing > > > pwrctrl-slot driver as a fallback? > > > > It would fit with no change, but the name "slot" doesn't match the goal > > here, > > it's not a slot at all, it's an actual pcie IC. > > > > How about renaming slot.cto something like pci-pwrctrl-simple.c, especially > if most power sequences fit into this category? This would follow the naming > example seen in other subsystems, such as drivers/mmc/core/pwrseq_simple.c. >
Yes. There is no point in duplicating the drivers just for a different name. Slot driver is relatively new. So I don't think there would be issues in renaming the module name. I'd prefer for 'pci-pwrctrl-generic.ko' for module name and 'generic.c' for driver name. - Mani -- மணிவண்ணன் சதாசிவம்
