On 1/27/26 10:57 AM, Neil Armstrong wrote:
> From: KancyJoe <[email protected]>
>
> Add initial Device Tree for the Ayaneo Pocket S2 gaming console based
> on the Qualcomm Snapdragon 8 Gen 3 platform.
>
> The design is similar to a phone without the modem, the game control
> is handled via a standalone controller connected to a PCIe USB
> controller.
>
> Display panel support will be added in a second time.
>
> Signed-off-by: KancyJoe <[email protected]>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
[...]
> + va-dai-link {
> + link-name = "VA Capture";
> +
> + codec {
> + sound-dai = <&lpass_vamacro 0>;
> + };
> +
> + cpu {
> + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
> + };
> +
> + platform {
> + sound-dai = <&q6apm>;
> + };
> + };
> +
> + dp-dai-link {
'd'p-dai-link < 'v'a-dai-link
[...]
> +&pm8550_gpios {
> + volume_up_n: volume-up-n-state {
> + pins = "gpio6";
> + function = "normal";
> + bias-pull-up;
> + input-enable;
> + power-source = <1>;
> + };
> +
> + pwm_fan_ctrl_active: pwm-fan-ctrl-active-state {
> + pins = "gpio9";
> + function = "func1";
> + output-low;
> + bias-disable;
> + power-source = <0>;
> + qcom,drive-strength = <3>; /* PMIC_GPIO_STRENGTH_LOW */
This is defined in include/dt-bindings/pinctrl/qcom,pmic-gpio.h,
you can just use it
[...]
> + upd720201_avdd33: upd720201-avdd33-state {
> + pins = "gpio123";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-low;
You should be able to drop all the output-low/high properties
since the device driver that references these GPIOs already asserts
that
otherwise lgtm
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
