On Wed, Jan 28, 2026 at 06:55:09PM +0100, Luca Ceresoli wrote:
> In case the channel0 is unavailable and bailing out from free_child is
> needed when we fail to add a DRM bridge for the available channel1,
> pointer pc->ch[0] in the bailout path would be NULL and it would be
> dereferenced as pc->ch[0]->bridge.next_bridge. Fix this by checking
> pc->ch[0] before dereferencing it.
>
> Fixes: 99764593528f ("drm/bridge: imx8qxp-pixel-combiner: convert to
> devm_drm_bridge_alloc() API")
> Reported-by: Liu Ying <[email protected]>
> Closes:
> https://lore.kernel.org/lkml/[email protected]/
> [Luca: backported on drm-misc-fixes where the original commit conflicts]
> Signed-off-by: Luca Ceresoli <[email protected]>
> ---
> drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
> b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
> index 8517b1c953d4..dc1cb094afd0 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
> @@ -349,7 +349,7 @@ static int imx8qxp_pc_bridge_probe(struct platform_device
> *pdev)
> free_child:
> of_node_put(child);
>
> - if (i == 1 && pc->ch[0]->next_bridge)
> + if (i == 1 && pc->ch[0] && pc->ch[0]->next_bridge)
> drm_bridge_remove(&pc->ch[0]->bridge);
>
> pm_runtime_disable(dev);
>
Tested-by: Liu Ying <[email protected]>
I'm not sure if there is any proper process to handle conflict between
this patch and commit [1] in drm-misc-next. If that's clear, I probably
add my R-b tag.
[1] commit ae754f049ce1 ("drm/bridge: imx8qxp-pixel-combiner: get/put the next
bridge")
--
Regards,
Liu Ying
