Dmitry Baryshkov <[email protected]> 于2026年1月30日周五 12:33写道： > > On Fri, Jan 30, 2026 at 11:07:38AM +0800, Xingjing Deng wrote: > > Yes, I found that. > > I will release patch v8. > > You have been notified once already. Please stop top-posting (aka > responding at the top of the message). >
Sorry about that, I just replied the email directly. > > Dmitry Baryshkov <[email protected]> 于2026年1月30日周五 10:38写道： > > > > > > On Fri, Jan 30, 2026 at 07:37:03AM +0800, Xingjing Deng wrote: > > > > In the SDSP probe path, qcom_scm_assign_mem() is used to assign the > > > > reserved memory to the configured VMIDs, but its return value was not > > > > checked. > > > > > > > > Fail the probe if the SCM call fails to avoid continuing with an > > > > unexpected/incorrect memory permission configuration. > > > > > > > > This issue was found by an in-house analysis workflow that extracts > > > > AST-based > > > > information and runs static checks, with LLM assistance for triage, and > > > > was > > > > confirmed by manual code review. > > > > No hardware testing was performed. > > > > > > > > Fixes: c3c0363bc72d4 ("misc: fastrpc: support complete DMA pool access > > > > to the DSP") > > > > Cc: [email protected] # 6.11-rc1 > > > > Signed-off-by: Xingjing Deng <[email protected]> > > > > --- > > > > v7: > > > > - Add the detail description of how the tool detect. > > > > - Link to v6: > > > > https://lore.kernel.org/linux-arm-msm/[email protected]/ > > > > > > > > v6: > > > > - Add description of the detection tool. > > > > - Link to v5: > > > > https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u > > > > > > > > v5: > > > > - Squash the functional change and indentation fix into a single patch. > > > > - Link to v4: > > > > https://lore.kernel.org/linux-arm-msm/2026011637-statute-showy-2c3f@gregkh/T/#t > > > > > > > > v4: > > > > - Format the indentation > > > > - Link to v3: > > > > https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t > > > > > > > > v3: > > > > - Add missing [email protected] to cc list. > > > > - Standarlize changelog placement/format. > > > > - Link to v2: > > > > https://lore.kernel.org/linux-arm-msm/[email protected]/T/#t > > > > > > > > v2: > > > > - Add Fixes: and Cc: stable tags. > > > > - Link to v1: > > > > https://lore.kernel.org/linux-arm-msm/[email protected]/T/#u > > > > --- > > > > drivers/misc/fastrpc.c | 5 ++++- > > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > > > > index ee652ef01534..8bac2216cb20 100644 > > > > --- a/drivers/misc/fastrpc.c > > > > +++ b/drivers/misc/fastrpc.c > > > > @@ -2337,8 +2337,11 @@ static int fastrpc_rpmsg_probe(struct > > > > rpmsg_device *rpdev) > > > > if (!err) { > > > > src_perms = BIT(QCOM_SCM_VMID_HLOS); > > > > > > > > - qcom_scm_assign_mem(res.start, > > > > resource_size(&res), &src_perms, > > > > + err = qcom_scm_assign_mem(res.start, > > > > resource_size(&res), &src_perms, > > > > data->vmperms, data->vmcount); > > > > + if (err) { > > > > + goto err_free_data; > > > > + } > > > > > > I think, checkpatch should warn here about unnecessary braces. > > > > > > > } > > > > > > > > } > > > > -- > > > > 2.25.1 > > > > > > > > > > -- > > > With best wishes > > > Dmitry > > -- > With best wishes > Dmitry
