Archit Anant <[email protected]> writes:
Hello Archit,
> Hi ChenYu,
>
> Thank you for the detailed review and the pointers toward the documentation.
> I will ensure the headers are sorted alphabetically and the driver name
> conflict is resolved in the next iteration.
>
>> The reset logic in mipi_dbi is inverted when compared to panel-st7789v.
>> mipi_dbi needs to be taught the "proper" reset polarity.
>
> Noted. I will look into the mipi_dbi core to see how to handle the reset
> polarity correctly.
>
>> Instead this functionality could be merged into the existing panel-st7789v
>> driver. You mentioned above that that driver only supports the 9-bit SPI
>> transfer mode. However porting that driver over to mipi_dbi would fix this,
>> and remove some redundant code. And tinydrm support could be added on top
>> of that.
>>
>> I actually mentioned I was going to work on this on IRC. But I only ported
>> the driver over to use mipi_dbi, and haven't gotten around to adding
>> tinydrm support. I can send out the conversion patches if that helps
>> you.
>
> That would be fantastic and would save a lot of redundant effort. If you
> send out the patches to convert the existing panel-st7789v driver to
> mipi_dbi, I would be happy to build the 'tiny' (simple display pipe)
> support on top of your series.
>
I think we want to get rid of the simple display pipeline and instead just
use regulator atomic helpers, even for the tiny DRM drivers.
Please take a look to previous commits such as 2037174993c8 ("drm/bochs:
Use regular atomic helpers") or 622113b9f11f ("drm/ssd130x: Replace simple
display helpers with the atomic helpers").
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
