Hi Biju,
Thanks for your review.
On Sun, Feb 15, 2026 at 08:11:37AM +0000, Biju Das wrote:
> Hi Tommaso,
>
> Thanks for the patch.
>
> > -----Original Message-----
> > From: Tommaso Merciai <[email protected]>
> > Sent: 13 February 2026 16:28
> > Subject: [PATCH v5 09/20] dt-bindings: display: renesas,rzg2l-du: Add
> > support for RZ/G3E SoC
> >
> > The RZ/G3E Soc has 2 LCD controller (LCDC), contain a Frame Compression
> > Processor (FCPVD), a Video
> > Signal Processor (VSPD), Video Signal Processor (VSPD), and Display Unit
> > (DU).
> >
> > - LCDC0 supports DSI and LVDS (single or dual-channel) outputs.
> > - LCDC1 supports DSI, LVDS (single-channel), and RGB outputs.
> >
> > Add new SoC-specific compatible string 'renesas,r9a09g047-du'.
> >
> > Signed-off-by: Tommaso Merciai <[email protected]>
> > ---
> > v4->v5:
> > - Dropped renesas,id property and updated bindings
> > accordingly.
> >
> > v2->v3:
> > - No changes.
> >
> > v2->v3:
> > - No changes.
> >
> > v1->v2:
> > - Use single compatible string instead of multiple compatible strings
> > for the two DU instances, leveraging a 'renesas,id' property to
> > differentiate between DU0 and DU1.
> > - Updated commit message accordingly.
> >
> > .../bindings/display/renesas,rzg2l-du.yaml | 22 +++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> > b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> > index 2cc66dcef870..be50b153d651 100644
> > --- a/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> > +++ b/Documentation/devicetree/bindings/display/renesas,rzg2l-du.yaml
> > @@ -20,6 +20,7 @@ properties:
> > - enum:
> > - renesas,r9a07g043u-du # RZ/G2UL
> > - renesas,r9a07g044-du # RZ/G2{L,LC}
> > + - renesas,r9a09g047-du # RZ/G3E
> > - renesas,r9a09g057-du # RZ/V2H(P)
> > - items:
> > - enum:
> > @@ -137,6 +138,27 @@ allOf:
> >
> > required:
> > - port@0
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: renesas,r9a09g047-du
> > + then:
> > + properties:
> > + ports:
> > + properties:
> > + port@0:
> > + description: DSI
> > + port@1:
> > + description: LVDS Channel 0
> > + port@2:
> > + description: LVDS Channel 1
> > + port@3:
> > + description: DPAD
> > +
> > + required:
> > + - port@0
> > + - port@1
>
>
> LCDC0 has port@0, port@1 and port@2
> LCDC1 has port@0, port@1 and port@3
>
> Looks like from the above port@2 and port@3 are optional??
>
> Also not sure to make port@1 for DPAD for consistency with RZ/G2L??
> Do you see any advantage by making port@1 for LVDS0?
DSI and LVDS channel 1 are the common ports for LCDC0 and LCDC1.
On v5 I mistakenly entered the wrong required ports.
I plan to update this ports numbering/description to:
properties:
ports:
properties:
port@0:
description: DSI
port@1:
description: DPAD
port@2:
description: LVDS, Channel 0
port@3:
description: LVDS, Channel 1
Also fixing the required ports to:
required:
- port@0
- port@3
I think I miss to update also the patternProperties to 3.
I'll fix that in v6.
Kind Regards,
Tommaso
> Cheers,
> Biju
>
>
