On 2/28/26 08:18, Randy Dunlap wrote: > Use the struct keyword for kernel-doc struct comments. > Use the correct enum names in enum amd_reset_method. > > This eliminates these warnings:
I was expecting that there would be a few more. ... > > Signed-off-by: Randy Dunlap <[email protected]> > --- > Cc: Alex Deucher <[email protected]> > Cc: Christian König <[email protected]> > Cc: [email protected] > Cc: Maarten Lankhorst <[email protected]> > Cc: Maxime Ripard <[email protected]> > Cc: Thomas Zimmermann <[email protected]> > Cc: David Airlie <[email protected]> > Cc: Simona Vetter <[email protected]> > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 39 ++++++++++++++------------ > 1 file changed, 21 insertions(+), 18 deletions(-) > > --- linux-next-20260227.orig/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ linux-next-20260227/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -462,7 +462,7 @@ int amdgpu_file_to_fpriv(struct file *fi > #define AMDGPU_MAX_WB 1024 /* Reserve at most 1024 WB slots for > amdgpu-owned rings. */ > > /** > - * amdgpu_wb - This struct is used for small GPU memory allocation. > + * struct amdgpu_wb - This struct is used for small GPU memory allocation. > * > * This struct is used to allocate a small amount of GPU memory that can be > * used to shadow certain states into the memory. This is especially useful > for > @@ -540,23 +540,26 @@ struct amdgpu_allowed_register_entry { > * enum amd_reset_method - Methods for resetting AMD GPU devices > * > * @AMD_RESET_METHOD_NONE: The device will not be reset. > - * @AMD_RESET_LEGACY: Method reserved for SI, CIK and VI ASICs. > - * @AMD_RESET_MODE0: Reset the entire ASIC. Not currently available for the > - * any device. > - * @AMD_RESET_MODE1: Resets all IP blocks on the ASIC (SDMA, GFX, VCN, etc.) > - * individually. Suitable only for some discrete GPU, not > - * available for all ASICs. > - * @AMD_RESET_MODE2: Resets a lesser level of IPs compared to MODE1. Which > IPs > - * are reset depends on the ASIC. Notably doesn't reset IPs > - * shared with the CPU on APUs or the memory controllers > (so > - * VRAM is not lost). Not available on all ASICs. > - * @AMD_RESET_LINK: Triggers SW-UP link reset on other GPUs > - * @AMD_RESET_BACO: BACO (Bus Alive, Chip Off) method powers off and on the > card > - * but without powering off the PCI bus. Suitable only for > - * discrete GPUs. > - * @AMD_RESET_PCI: Does a full bus reset using core Linux subsystem PCI reset > - * and does a secondary bus reset or FLR, depending on what > the > - * underlying hardware supports. > + * @AMD_RESET_METHOD_LEGACY: Method reserved for SI, CIK and VI ASICs. > + * @AMD_RESET_METHOD_MODE0: Reset the entire ASIC. Not currently available > + * for the any device. > + * @AMD_RESET_METHOD_MODE1: Resets all IP blocks on the ASIC (SDMA, GFX, VCN, > + * etc.) individually. Suitable only for some discrete > + * GPU, not available for all ASICs. > + * @AMD_RESET_METHOD_MODE2: Resets a lesser level of IPs compared to MODE1. > + * Which IPs are reset depends on the ASIC. Notably > + * doesn't reset IPs shared with the CPU on APUs or > + * the memory controllers (so VRAM is not lost). > + * Not available on all ASICs. > + * @AMD_RESET_METHOD_LINK: Triggers SW-UP link reset on other GPUs > + * @AMD_RESET_METHOD_BACO: BACO (Bus Alive, Chip Off) method powers off and > on > + * the card but without powering off the PCI bus. > + * Suitable only for discrete GPUs. > + * @AMD_RESET_METHOD_PCI: Does a full bus reset using core Linux subsystem > + * PCI reset and does a secondary bus reset or FLR, > + * depending on what the underlying hardware supports. > + * @AMD_RESET_METHOD_ON_INIT: Does a device reset during the driver init > + * sequence. Looks like a good idea in general, but I'm really wondering why we have the define in amdgpu.h in the first place. While at it please move the enum to amdgpu_reset.h and eventually only forward declare it in amdgpu.h Apart from that the patch looks good to me. Thanks, Christian. > * > * Methods available for AMD GPU driver for resetting the device. Not all > * methods are suitable for every device. User can override the method using
