On Mon, Mar 02, 2026 at 09:04:07PM +0900, Alexandre Courbot wrote:
> > +    // PRAMIN support is only for MMU v2 for now (Turing/Ampere/Ada).
> > +    if mmu_version != MmuVersion::V2 {
>
> Why is that? I thought PRAMIN was also working on Hopper+. Isn't it
> orthogonal to the kind of MMU used?

The PRAMIN aperture window register changed on Hopper+: pre-Hopper uses
NV_PBUS_BAR0_WINDOW while Hopper+ uses NV_XAL_EP_BAR0_WINDOW. Our
current code only programs the former, so we'd need a HAL to support
both. For now, V2-only is the safe choice. I've updated the comment to
explain this.

> > +    // Test 1: Read/write at byte-aligned locations.
>
> Let's split each test into its own function for readability.

Done.

thanks,

--
Joel Fernandes

Reply via email to