On Thu, 2026-03-12 at 10:30 +0530, Animesh Manna wrote:
> Unused bandwidth can be used by external display agents for Panel
> Replay
> enabled DP panel during idleness with link on. This patch series
> enabling the same.

Generic comment on this patch set. Maybe we should add one more patch
with "Fixes" tag:

Fixes: e60cff453b82 ("drm/i915/dp: Enable DP tunnel BW allocation
mode")
Cc: Imre Deak <[email protected]>
Cc: <[email protected]> # v6.9+

This patch would just add:

if (intel_dp_tunnel_bw_alloc_is_enabled(intel_dp)) {
        drm_dbg_kms(display->drm,
                    "Panel Replay is disabled as DP tunneling
enabled\n");
        return false;
}

into _panel_replay_compute_config. this could be first patch in your
set. What do you think?

BR,
Jouni Högander

> 
> Signed-off-by: Animesh Manna <[email protected]>
> 
> Animesh Manna (3):
>   drm/i915/display: Add drm helper to check pr optimization support
>   drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling
>   drm/i915/display: Disable Panel Replay for DP-tunneling without
>     optimization
> 
>  drivers/gpu/drm/display/drm_dp_tunnel.c       | 17 ++++++++++
>  .../gpu/drm/i915/display/intel_display_regs.h |  1 +
>  .../gpu/drm/i915/display/intel_dp_tunnel.c    | 14 +++++++++
>  .../gpu/drm/i915/display/intel_dp_tunnel.h    |  6 ++++
>  drivers/gpu/drm/i915/display/intel_psr.c      | 31
> +++++++++++++++++--
>  include/drm/display/drm_dp_tunnel.h           |  6 ++++
>  6 files changed, 73 insertions(+), 2 deletions(-)
> 

Reply via email to