Re: [PATCH v2 1/2] gpu: nova: rename drivers to use kebab-case convention

[John Hubbard]

On 3/16/26 5:08 AM, Cheng-Yang Chou wrote:

Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
driver from "Nova" to "nova-drm" to follow kernel naming conventions
before these names become UAPI (e.g. exposed via driver_override).

Also fix the nova-drm driver description from "Nvidia Graphics" to
"NVIDIA Graphics and Compute".

Link: https://github.com/Rust-for-Linux/linux/issues/1228
Signed-off-by: Cheng-Yang Chou <yphbchou0...@gmail.com>
Acked-by: Timur Tabi <tt...@nvidia.com>
---
  drivers/gpu/drm/nova/driver.rs     | 6 +++---
  drivers/gpu/drm/nova/nova.rs       | 2 +-
  drivers/gpu/nova-core/nova_core.rs | 2 +-
  3 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: John Hubbard <jhubb...@nvidia.com>


thanks,
--
John Hubbard

diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
index b1af0a099551..e3de04f358f0 100644
--- a/drivers/gpu/drm/nova/driver.rs
+++ b/drivers/gpu/drm/nova/driver.rs
@@ -32,11 +32,11 @@ pub(crate) struct NovaData {
      major: 0,
      minor: 0,
      patchlevel: 0,
-    name: c"nova",
-    desc: c"Nvidia Graphics",
+    name: c"nova-drm",
+    desc: c"NVIDIA Graphics and Compute",
  };

-const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";

+const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
  const AUXILIARY_NAME: &CStr = c"nova-drm";

kernel::auxiliary_device_table!(

diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
index 8893e58ee0db..1fd454c7e0df 100644
--- a/drivers/gpu/drm/nova/nova.rs
+++ b/drivers/gpu/drm/nova/nova.rs
@@ -10,7 +10,7 @@

kernel::module_auxiliary_driver! {

      type: NovaDriver,
-    name: "Nova",
+    name: "nova-drm",
      authors: ["Danilo Krummrich"],
      description: "Nova GPU driver",
      license: "GPL v2",
diff --git a/drivers/gpu/nova-core/nova_core.rs 
b/drivers/gpu/nova-core/nova_core.rs
index c1121e7c64c5..90e98380687b 100644
--- a/drivers/gpu/nova-core/nova_core.rs
+++ b/drivers/gpu/nova-core/nova_core.rs
@@ -22,7 +22,7 @@

kernel::module_pci_driver! {

      type: driver::NovaCore,
-    name: "NovaCore",
+    name: "nova-core",
      authors: ["Danilo Krummrich"],
      description: "Nova Core GPU driver",
      license: "GPL v2",