On Mon Mar 16, 2026 at 1:08 PM CET, Cheng-Yang Chou wrote:
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index b1af0a099551..e3de04f358f0 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -32,11 +32,11 @@ pub(crate) struct NovaData {
> major: 0,
> minor: 0,
> patchlevel: 0,
> - name: c"nova",
> - desc: c"Nvidia Graphics",
> + name: c"nova-drm",
> + desc: c"NVIDIA Graphics and Compute",
> };
Can you please move this into the second patch. Additionally, in the second
patch, please only keep the Kconfig change and use the following in the
Makefile.
obj-$(CONFIG_DRM_NOVA) += nova-drm.o
nova-drm-y := nova.o
I.e. keep the directory and filenames as they are.
We can use the same trick for nova-core, so we get nova-core.ko and nova-drm.ko.
Thanks,
Danilo
>
> -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
> +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
> const AUXILIARY_NAME: &CStr = c"nova-drm";
>
> kernel::auxiliary_device_table!(
> diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
> index 8893e58ee0db..1fd454c7e0df 100644
> --- a/drivers/gpu/drm/nova/nova.rs
> +++ b/drivers/gpu/drm/nova/nova.rs
> @@ -10,7 +10,7 @@
>
> kernel::module_auxiliary_driver! {
> type: NovaDriver,
> - name: "Nova",
> + name: "nova-drm",
> authors: ["Danilo Krummrich"],
> description: "Nova GPU driver",
> license: "GPL v2",
> diff --git a/drivers/gpu/nova-core/nova_core.rs
> b/drivers/gpu/nova-core/nova_core.rs
> index c1121e7c64c5..90e98380687b 100644
> --- a/drivers/gpu/nova-core/nova_core.rs
> +++ b/drivers/gpu/nova-core/nova_core.rs
> @@ -22,7 +22,7 @@
>
> kernel::module_pci_driver! {
> type: driver::NovaCore,
> - name: "NovaCore",
> + name: "nova-core",
> authors: ["Danilo Krummrich"],
> description: "Nova Core GPU driver",
> license: "GPL v2",
> --
> 2.48.1
