Re: [PATCH 08/13] drm/meson: dw-hdmi: Use local dev variable consistently in bind()

[Neil Armstrong]

On 5/18/26 21:47, Jonas Karlman wrote:

Replace indirect struct device accesses via pdev->dev with the local dev
parameter already available in meson_dw_hdmi_bind(), for consistency and
readability.

Signed-off-by: Jonas Karlman <jo...@kwiboo.se>
---
  drivers/gpu/drm/meson/meson_dw_hdmi.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c 
b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index 30099bf71aad..fcd2426af9fc 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -671,9 +671,9 @@ static int meson_dw_hdmi_bind(struct device *dev, struct 
device *master,

DRM_DEBUG_DRIVER("\n"); - match = of_device_get_match_data(&pdev->dev);

+       match = of_device_get_match_data(dev);
        if (!match) {
-               dev_err(&pdev->dev, "failed to get match data\n");
+               dev_err(dev, "failed to get match data\n");
                return -ENODEV;
        }

@@ -771,7 +771,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,

                return PTR_ERR(meson_dw_hdmi->hdmi);
        }

- meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(pdev->dev.of_node);

+       meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(dev->of_node);
        if (!meson_dw_hdmi->bridge) {
                devm_free_irq(dev, irq, meson_dw_hdmi);
                dw_hdmi_remove(meson_dw_hdmi->hdmi);

Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org>

Thanks,
Neil