From: Jérôme de Bretagne <[email protected]>

Align the Surface Pro 9 5G with the other sc8280xp-based models as done in
this patch series [1] from Bartosz.

Add a node for the PMU of the WCN6855 and rework the inputs of the wifi
and bluetooth nodes to consume the PMU's outputs.

With this we can drop the regulator-always-on properties from vreg_s11b
and vreg_s12b as they will now be enabled by the power sequencing
driver.

Use the fixed BT vddrfa1p7-supply supply name to align with bindings.

[1] 
https://lore.kernel.org/all/[email protected]/

Cc: Bartosz Golaszewski <[email protected]>
Signed-off-by: Jérôme de Bretagne <[email protected]>
---
 .../boot/dts/qcom/sc8280xp-microsoft-arcata.dts    | 103 ++++++++++++++++++---
 1 file changed, 89 insertions(+), 14 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts 
b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
index 
4daff3a0ecf48ad2081a2fe98910adf0debef88f..52d8e9527bd26f97305905650e2486a59e6d7157
 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
@@ -357,6 +357,70 @@ usb1_sbu_mux: endpoint {
                        };
                };
        };
+
+       wcn6855-pmu {
+               compatible = "qcom,wcn6855-pmu";
+
+               pinctrl-0 = <&bt_default>, <&wlan_en>;
+               pinctrl-names = "default";
+
+               wlan-enable-gpios = <&tlmm 134 GPIO_ACTIVE_HIGH>;
+               bt-enable-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
+               swctrl-gpios = <&tlmm 132 GPIO_ACTIVE_HIGH>;
+
+               vddio-supply = <&vreg_s10b>;
+               vddaon-supply = <&vreg_s12b>;
+               vddpmu-supply = <&vreg_s12b>;
+               vddpmumx-supply = <&vreg_s12b>;
+               vddpmucx-supply = <&vreg_s12b>;
+               vddrfa0p95-supply = <&vreg_s12b>;
+               vddrfa1p3-supply = <&vreg_s11b>;
+               vddrfa1p9-supply = <&vreg_s1c>;
+               vddpcie1p3-supply = <&vreg_s11b>;
+               vddpcie1p9-supply = <&vreg_s1c>;
+
+               regulators {
+                       vreg_pmu_rfa_cmn_0p8: ldo0 {
+                               regulator-name = "vreg_pmu_rfa_cmn_0p8";
+                       };
+
+                       vreg_pmu_aon_0p8: ldo1 {
+                               regulator-name = "vreg_pmu_aon_0p8";
+                       };
+
+                       vreg_pmu_wlcx_0p8: ldo2 {
+                               regulator-name = "vreg_pmu_wlcx_0p8";
+                       };
+
+                       vreg_pmu_wlmx_0p8: ldo3 {
+                               regulator-name = "vreg_pmu_wlmx_0p8";
+                       };
+
+                       vreg_pmu_btcmx_0p8: ldo4 {
+                               regulator-name = "vreg_pmu_btcmx_0p8";
+                       };
+
+                       vreg_pmu_pcie_1p8: ldo5 {
+                               regulator-name = "vreg_pmu_pcie_1p8";
+                       };
+
+                       vreg_pmu_pcie_0p9: ldo6 {
+                               regulator-name = "vreg_pmu_pcie_0p9";
+                       };
+
+                       vreg_pmu_rfa_0p8: ldo7 {
+                               regulator-name = "vreg_pmu_rfa_0p8";
+                       };
+
+                       vreg_pmu_rfa_1p2: ldo8 {
+                               regulator-name = "vreg_pmu_rfa_1p2";
+                       };
+
+                       vreg_pmu_rfa_1p7: ldo9 {
+                               regulator-name = "vreg_pmu_rfa_1p7";
+                       };
+               };
+       };
 };
 
 &apps_rsc {
@@ -383,7 +447,6 @@ vreg_s11b: smps11 {
                        regulator-min-microvolt = <1272000>;
                        regulator-max-microvolt = <1272000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-always-on;
                };
 
                vreg_s12b: smps12 {
@@ -391,7 +454,6 @@ vreg_s12b: smps12 {
                        regulator-min-microvolt = <984000>;
                        regulator-max-microvolt = <984000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-always-on;
                };
 
                vreg_l3b: ldo3 {
@@ -653,6 +715,16 @@ wifi@0 {
                compatible = "pci17cb,1103";
                reg = <0x10000 0x0 0x0 0x0 0x0>;
 
+               vddrfacmn-supply = <&vreg_pmu_rfa_cmn_0p8>;
+               vddaon-supply = <&vreg_pmu_aon_0p8>;
+               vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+               vddwlmx-supply = <&vreg_pmu_wlmx_0p8>;
+               vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
+               vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
+               vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+               vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+               vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
+
                qcom,calibration-variant = "MS_SP9_5G";
        };
 };
@@ -837,20 +909,16 @@ &uart2 {
        bluetooth {
                compatible = "qcom,wcn6855-bt";
 
-               vddio-supply = <&vreg_s10b>;
-               vddbtcxmx-supply = <&vreg_s12b>;
-               vddrfacmn-supply = <&vreg_s12b>;
-               vddrfa0p8-supply = <&vreg_s12b>;
-               vddrfa1p2-supply = <&vreg_s11b>;
-               vddrfa1p7-supply = <&vreg_s1c>;
+               vddrfacmn-supply = <&vreg_pmu_rfa_cmn_0p8>;
+               vddaon-supply = <&vreg_pmu_aon_0p8>;
+               vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+               vddwlmx-supply = <&vreg_pmu_wlmx_0p8>;
+               vddbtcmx-supply = <&vreg_pmu_btcmx_0p8>;
+               vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+               vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+               vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>;
 
                max-speed = <3200000>;
-
-               enable-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
-               swctrl-gpios = <&tlmm 132 GPIO_ACTIVE_HIGH>;
-
-               pinctrl-0 = <&bt_default>;
-               pinctrl-names = "default";
        };
 };
 
@@ -1201,4 +1269,11 @@ reset-pins {
                        bias-disable;
                };
        };
+
+       wlan_en: wlan-en-state {
+               pins = "gpio134";
+               function = "gpio";
+               drive-strength = <8>;
+               bias-pull-down;
+       };
 };

-- 
2.47.3


Reply via email to