Re: [PATCH v7 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing

[Jianping Li]

On 6/2/2026 5:25 PM, Jie Gan wrote:

On 6/2/2026 3:17 PM, Jianping Li wrote:

Audio PD static process creation assumes that a reserved-memory
region is defined in DT and exposed via cctx->remote_heap.

If reserved-memory is missing or incomplete, the driver may pass
invalid address/size information to the DSP, leading to undefined
behavior or crashes.

Add explicit validation for remote_heap presence and size before
sending the memory to DSP, and fail early if the configuration is
invalid.

Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd")
Cc: sta...@kernel.org
Signed-off-by: Jianping Li <jianping...@oss.qualcomm.com>
---
  drivers/misc/fastrpc.c | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index a8a58f889d07..f46a8f53970d 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c

@@ -1354,6 +1354,13 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,

      } inbuf;
      u32 sc;
  +    if (!fl->cctx->remote_heap ||
+        !fl->cctx->remote_heap->dma_addr ||
+        !fl->cctx->remote_heap->size) {
+        err = -ENOMEM;

+        dev_dbg(fl->sctx->dev, "remote heap memory region is not added\n");

should be an error instead of dbg info.

Thanks,
Jie

I will use dev_err to print this log.

Thanks,

Jianping.

+        return err;
+    }
      args = kzalloc_objs(*args, FASTRPC_CREATE_STATIC_PROCESS_NARGS);
      if (!args)
          return -ENOMEM;