Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The top-level `clock-names` property enforces a strict positional sequence (`core`, `axi`, `ahb`, `pix0`, `pix1`) that conflicts with the `nuvoton,ma35d1-dcu` variant, causing valid device trees to fail schema validation. --
commit 644d6513333f2ad52d35609ed1c0190fdeaa8192 Author: Joey Lu <[email protected]> dt-bindings: display: verisilicon,dc: generalize for single-output variants This commit generalizes the verisilicon,dc schema to support single-output variants. It extracts variant-specific constraints into allOf/if blocks and adds support for the Nuvoton MA35D1 SoC. > diff --git a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml > b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml > --- a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml > +++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml [ ... ] > clock-names: > + minItems: 2 > + maxItems: 5 > items: > - const: core > - const: axi > - const: ahb > - const: pix0 > - const: pix1 [ ... ] > + - if: > + properties: > + compatible: > + contains: > + const: nuvoton,ma35d1-dcu > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + items: > + - description: DC Core clock > + - description: Pixel clock of output 0 > + > + clock-names: > + minItems: 2 > + maxItems: 2 [Severity: Medium] Will this cause validation failures for valid device trees? The top-level clock-names defines a strict positional sequence where the second item must be "axi". However, the clocks definition for the nuvoton,ma35d1-dcu variant indicates it uses "core" and "pix0". Since the variant's clock-names block doesn't redefine the items array, won't dt-schema evaluate "pix0" against the inherited "axi" constraint at index 1 and fail? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
