The recently introduced `GspBootContext` is useful in at least two other places:
- As a replacement for the sequencer's `GspSequencerParams`, - As the main parameter of `Gsp::unload`, for symmetry with `Gsp::boot`. This symmetry can be further exploited to make `Gsp::boot` and `Gsp::unload` generic over the exact boot context required for the current chip. Doing so requires some more preliminary work that goes beyond this series, but this groundwork is needed regardless. Another cleanup that can be performed as a consequence is the removal of the `BootUnloadGuard`. This type is cumbersome as it holds extra references to the boot context, making it difficult to make some of these references mutable (as we want to do with the `Falcon`s that should require exclusive access to load and run firmware). Furthermore, it is only needed a single time in `Gsp::boot`. By running the boot process in a local closure, we can catch errors and call `Gsp::unload` on the unload bundle just as efficiently, and with less code. Building on this, the series also introduces a proper type for identifying the GSP boot method, and moves the `Fsp` instance to `Gpu` to make it available outside of the GSP boot process. This will be notably useful for vGPU support [1]. This series applies on `drm-rust-next`. [1] https://lore.kernel.org/all/[email protected]/ Signed-off-by: Alexandre Courbot <[email protected]> --- Changes in v2: - Replace nonexistent `ENODATA` with the more appropriate `EAGAIN`. - Add patches introducing `GspBootMethod`. - Add patches moving `Fsp` to `Gpu`. - Link to v1: https://patch.msgid.link/[email protected] --- Alexandre Courbot (13): gpu: nova-core: gsp: sequencer: use GspBootContext gpu: nova-core: gsp: sequencer: do not store sequence into GspSequencer gpu: nova-core: gsp: move boot code into local closure gpu: nova-core: gsp: replace BootUnloadGuard with local handler gpu: nova-core: gsp: move unload bundle error handling to Gsp::boot gpu: nova-core: gsp: make unload take GspBootContext gpu: nova-core: gsp: fold TU102 unload bundle construction into HAL method gpu: nova-core: gsp: turn FWSEC execution into HAL method gpu: nova-core: gsp: make use of FWSEC bootloader a property of the TU102 HAL gpu: nova-core: introduce GspBootMethod gpu: nova-core: avoid repeated calls to pci::Device::as_ref gpu: nova-core: gsp: pass GspBootContext mutably gpu: nova-core: store Fsp instance in Gpu drivers/gpu/nova-core/firmware.rs | 25 ++- drivers/gpu/nova-core/firmware/fwsec.rs | 5 +- drivers/gpu/nova-core/gpu.rs | 68 +++--- drivers/gpu/nova-core/gsp.rs | 44 +++- drivers/gpu/nova-core/gsp/boot.rs | 142 +++++------- drivers/gpu/nova-core/gsp/hal.rs | 63 +++--- drivers/gpu/nova-core/gsp/hal/ga102.rs | 14 ++ drivers/gpu/nova-core/gsp/hal/gh100.rs | 62 +++-- drivers/gpu/nova-core/gsp/hal/tu102.rs | 385 +++++++++++++++----------------- drivers/gpu/nova-core/gsp/sequencer.rs | 71 +++--- 10 files changed, 436 insertions(+), 443 deletions(-) --- base-commit: f0c1bb8ead8a9790e7d0339354598b50a9c6789a change-id: 20260619-nova-bootcontext-401d6107e8fb Best regards, -- Alexandre Courbot <[email protected]>
